Skip to content

Commit bdf8ac3

Browse files
fix: merge errors
Signed-off-by: Andreas Reichel <andreas@manticore-projects.com>
1 parent 7c4ca96 commit bdf8ac3

2 files changed

Lines changed: 13 additions & 18 deletions

File tree

‎src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3375,8 +3375,6 @@ TOKEN: /* Reserved SQL Keywords and structural tokens */
33753375
| <K_ELSE:"ELSE">
33763376
| <K_EXCEPT: "EXCEPT">
33773377
| <K_EXCLUDES: "EXCLUDES"> /* Salesforce SOQL */
3378-
| <K_EXISTS:"EXISTS">
3379-
| <K_FBV:"FBV">
33803378
| <K_FETCH:"FETCH">
33813379
| <K_FINAL: "FINAL">
33823380
| <K_FALSE: "FALSE">
@@ -3430,7 +3428,6 @@ TOKEN: /* Reserved SQL Keywords and structural tokens */
34303428
| <K_QUALIFY: "QUALIFY">
34313429
| <K_RETURNING: "RETURNING">
34323430
| <K_RIGHT:"RIGHT">
3433-
| <K_SCRIPT: "SCRIPT">
34343431
| <K_SELECT: ("SELECT" | "SEL")>
34353432
| <K_SEMI : "SEMI">
34363433
| <K_SET:"SET">

‎src/test/java/net/sf/jsqlparser/statement/KeywordsTest.java‎

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import net.sf.jsqlparser.expression.NotExpression;
1919
import net.sf.jsqlparser.expression.MapExpression;
2020
import net.sf.jsqlparser.expression.JdbcNamedParameter;
21-
import net.sf.jsqlparser.expression.TernaryExpression;
2221
import net.sf.jsqlparser.expression.operators.relational.EqualsTo;
2322
import net.sf.jsqlparser.expression.operators.relational.InExpression;
2423
import net.sf.jsqlparser.expression.operators.relational.ExistsExpression;
@@ -100,19 +99,18 @@ public void testSampleExtendAsIdentifier() throws JSQLParserException {
10099
}
101100

102101
@ParameterizedTest
103-
@ValueSource(strings = {"sample", "extend", "SaMpLe", "ExTeNd"})
102+
@ValueSource(strings = {"exists", "sample", "extend", "SaMpLe", "ExTeNd"})
104103
void testSampleExtendImplicitAliases(String keyword) throws JSQLParserException {
105-
// exists is a non-reserved keyword in the common dialects and reaches the
106-
// parser as an ordinary column name in downstream rewriting tools.
107-
@Test
108-
public void testExistsAsIdentifier() throws JSQLParserException {
109-
assertSqlCanBeParsedAndDeparsed("SELECT exists FROM mytable", true);
110-
assertSqlCanBeParsedAndDeparsed("SELECT mytable.exists FROM mytable", true);
111-
assertSqlCanBeParsedAndDeparsed("SELECT * FROM mytable WHERE exists = 1", true);
112-
assertSqlCanBeParsedAndDeparsed("SELECT * FROM mytable ORDER BY exists", true);
113-
assertSqlCanBeParsedAndDeparsed("UPDATE mytable SET exists = 1 WHERE id = 1", true);
114-
assertSqlCanBeParsedAndDeparsed("INSERT INTO mytable (exists) VALUES (1)", true);
115-
assertSqlCanBeParsedAndDeparsed("SELECT a AS exists FROM mytable", true);
104+
// keyword is a non-reserved keyword in the common dialects and reaches the
105+
// parser as an ordinary column name in downstream rewriting tools.
106+
assertSqlCanBeParsedAndDeparsed("SELECT " + keyword + " FROM mytable", true);
107+
assertSqlCanBeParsedAndDeparsed("SELECT mytable.\" + keyword + \" FROM mytable", true);
108+
assertSqlCanBeParsedAndDeparsed("SELECT * FROM mytable WHERE \" + keyword + \" = 1", true);
109+
assertSqlCanBeParsedAndDeparsed("SELECT * FROM mytable ORDER BY \" + keyword + \"", true);
110+
assertSqlCanBeParsedAndDeparsed("UPDATE mytable SET \" + keyword + \" = 1 WHERE id = 1",
111+
true);
112+
assertSqlCanBeParsedAndDeparsed("INSERT INTO mytable (\" + keyword + \") VALUES (1)", true);
113+
assertSqlCanBeParsedAndDeparsed("SELECT a AS \" + keyword + \" FROM mytable", true);
116114
}
117115

118116
// the guarded keyword form keeps its operator meaning
@@ -208,7 +206,7 @@ void testSampleExtendPipeExpression(String keyword) throws JSQLParserException {
208206
assertEquals(keyword, assertInstanceOf(Function.class,
209207
select.getSelectItem(0).getExpression()).getName());
210208
}
211-
209+
212210
@Test
213211
void testExistsColumnWithOracleJoin() throws JSQLParserException {
214212
PlainSelect select = (PlainSelect) assertSqlCanBeParsedAndDeparsed(
@@ -311,7 +309,7 @@ void testExistsBeforeNestedTernary() throws JSQLParserException {
311309
.getColumnName());
312310
assertInstanceOf(TernaryExpression.class, map.getEntries().get(0).getValue());
313311
}
314-
312+
315313
// ERRORS introduces Exasol's IMPORT/EXPORT error clauses but is an ordinary name elsewhere,
316314
// e.g. a DuckDB column holding the errors of an upstream step.
317315
@Test

0 commit comments

Comments
 (0)