From 23e6846e9ee795eb26a70c7bbc58a49e167c68e8 Mon Sep 17 00:00:00 2001 From: Jeppe Fredsgaard Blaabjerg Date: Thu, 8 Oct 2026 17:24:34 +0200 Subject: [PATCH] test(manifest): key Maven repo-inheritance roots by project id Project records are keyed group:artifact:version since each JVM build project got its own id, so matching roots by bare module name found none and the smoke test failed on every Maven version. --- .../scripts/test/maven-compat/smoke-test-repo-inheritance.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/commands/manifest/scripts/test/maven-compat/smoke-test-repo-inheritance.sh b/src/commands/manifest/scripts/test/maven-compat/smoke-test-repo-inheritance.sh index 447756674..d3b9776a4 100755 --- a/src/commands/manifest/scripts/test/maven-compat/smoke-test-repo-inheritance.sh +++ b/src/commands/manifest/scripts/test/maven-compat/smoke-test-repo-inheritance.sh @@ -52,6 +52,7 @@ for r in rows: WIDGET = 'demo.scoped:widget:jar:1.0' LIBA = 'demo:liba:1.0' +LIBB = 'demo:libb:1.0' errors = [] if failures: @@ -60,7 +61,7 @@ if failures: def roots_for(project_key): return {rid for rid, key in roots.items() if key == project_key} -for project_key in ('liba', 'libb'): +for project_key in (LIBA, LIBB): rids = roots_for(project_key) if not rids: errors.append(f"no root record for module {project_key!r}") @@ -69,7 +70,7 @@ for project_key in ('liba', 'libb'): errors.append(f"{WIDGET} missing from {project_key}'s graph") # The point of the fixture: libb reaches widget only through the reactor module liba. -if not any(rid in roots_for('libb') and p == LIBA and c == WIDGET for rid, p, c in edges): +if not any(rid in roots_for(LIBB) and p == LIBA and c == WIDGET for rid, p, c in edges): errors.append(f"no {LIBA} -> {WIDGET} edge in libb's root") jars = [p for p in files.get(WIDGET, ()) if p.endswith('.jar')]