From 483f98ddd45c93699317fce37c00cdec84c7e955 Mon Sep 17 00:00:00 2001 From: Ramesh Padmanabhaiah <22363102+codeforester@users.noreply.github.com> Date: Sat, 10 Oct 2026 07:01:37 +0530 Subject: [PATCH 1/2] ci: use explicit release notes --- .github/workflows/package.yml | 1 - tests/test_package_workflow.py | 7 +++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml index c2fb63d..30ffb32 100644 --- a/.github/workflows/package.yml +++ b/.github/workflows/package.yml @@ -496,7 +496,6 @@ jobs: gh release create "$tag" "${assets[@]}" \ --repo "$GITHUB_REPOSITORY" \ --title "$tag" \ - --generate-notes \ --notes "Published distributions and release metadata for $tag. See CHANGELOG.md for the reviewed release notes." \ || create_status=$? diff --git a/tests/test_package_workflow.py b/tests/test_package_workflow.py index e564edd..773fb6c 100644 --- a/tests/test_package_workflow.py +++ b/tests/test_package_workflow.py @@ -46,6 +46,13 @@ def test_package_workflow_does_not_replace_published_release_assets() -> None: assert "--clobber" not in workflow +def test_package_workflow_uses_explicit_release_notes() -> None: + workflow = (Path(__file__).resolve().parents[1] / ".github/workflows/package.yml").read_text(encoding="utf-8") + + assert "--generate-notes" not in workflow + assert '--notes "Published distributions and release metadata for $tag. See CHANGELOG.md for the reviewed release notes."' in workflow + + def test_package_workflow_gates_writes_on_release_provenance() -> None: workflow = (Path(__file__).resolve().parents[1] / ".github/workflows/package.yml").read_text(encoding="utf-8") jobs = yaml.safe_load(workflow)["jobs"] From 5a1bce905cf93d8d07d5a86f056e0cfd422d67ec Mon Sep 17 00:00:00 2001 From: Ramesh Padmanabhaiah <22363102+codeforester@users.noreply.github.com> Date: Sat, 10 Oct 2026 07:06:26 +0530 Subject: [PATCH 2/2] test: format release workflow assertion --- tests/test_package_workflow.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/test_package_workflow.py b/tests/test_package_workflow.py index 773fb6c..88d0bee 100644 --- a/tests/test_package_workflow.py +++ b/tests/test_package_workflow.py @@ -50,7 +50,10 @@ def test_package_workflow_uses_explicit_release_notes() -> None: workflow = (Path(__file__).resolve().parents[1] / ".github/workflows/package.yml").read_text(encoding="utf-8") assert "--generate-notes" not in workflow - assert '--notes "Published distributions and release metadata for $tag. See CHANGELOG.md for the reviewed release notes."' in workflow + assert ( + '--notes "Published distributions and release metadata for $tag. See CHANGELOG.md for the reviewed release notes."' + in workflow + ) def test_package_workflow_gates_writes_on_release_provenance() -> None: