fix(core): finish removing semantic_search_enabled after today's merges

#1696 removed `semantic_search_enabled` from BasicMemoryConfig, but it was
tested against a main that predated several milestone merges that still
read the flag, so main failed static checks and most test jobs:

- `index_project_and_report_readiness` (#1704) passed
  `embeddings=app_config.semantic_search_enabled`, which raised
  AttributeError on every `bm project add`. Semantic search is always on,
  so the add always runs the embedding pass.
- test_db_reindex (#1704) parametrized the add on the flag; it now
  asserts the embedding pass runs.
- test_deferred_embedding_resume (#1700) set the flag on its config.
- test_config_env_overrides_not_persisted (#1701) used the flag as its
  example env-overridden boolean; it now uses `format_on_save`.

Also makes #1704's cloud-prune test compare against str(Path) so it holds
on Windows, where the path prints with backslashes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01APFUk2bjEwMptMQqpRhjea
Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/cli/commands/db.py

@@ -311,12 +311,10 @@ async def index_project_and_report_readiness(project: str) -> None:
     already-indexed project only redoes what changed.
     """
     app_config = ConfigManager().config
-    # Semantic search off is a supported configuration, not a failure, so the
-    # embedding pass is skipped without the warning an explicit reindex prints.
     await _reindex(
         app_config,
         search=True,
-        embeddings=app_config.semantic_search_enabled,
+        embeddings=True,
         full=False,
         project=project,
     )

tests/cli/cloud/test_project_sync_command.py

@@ -915,12 +915,14 @@ def test_cloud_prune_names_the_bmignore_in_the_config_dir(monkeypatch, config_ma
     """The scan message names the real ignore file, not a hardcoded ~/.basic-memory (#1635)."""
     module = importlib.import_module("basic_memory.cli.commands.cloud.project_sync")
     _stub_prune_env(monkeypatch, module, matches=[])
-    monkeypatch.setattr(module, "get_bmignore_path", lambda: Path("/cfg/.bmignore"))
+    bmignore = Path("/cfg/.bmignore")
+    monkeypatch.setattr(module, "get_bmignore_path", lambda: bmignore)
 
     result = runner.invoke(app, ["cloud", "prune", "--name", "research", "--dry-run"])
 
     assert result.exit_code == 0, result.output
-    assert "matching /cfg/.bmignore" in " ".join(result.output.split())
+    # str(Path) so the expectation matches the platform's separators (Windows CI).
+    assert f"matching {bmignore}" in " ".join(result.output.split())
 
 
 def test_cloud_prune_help_points_at_the_config_dir():

tests/cli/test_db_reindex.py

@@ -883,17 +883,14 @@ def test_reindex_embedding_success_reports_index_and_model_and_exits_zero(
 
 
 @pytest.mark.asyncio
-@pytest.mark.parametrize("semantic_search_enabled", [True, False])
-async def test_project_add_indexing_runs_the_reindex_pass_then_reports_readiness(
-    monkeypatch, semantic_search_enabled: bool
-):
+async def test_project_add_indexing_runs_the_reindex_pass_then_reports_readiness(monkeypatch):
     """`project add` reuses the reindex pass, so its embedding phase shows the progress bar.
 
     The old path made one foreground API request that embedded inline and printed
-    nothing until it returned. Embeddings follow the config here, without the
-    "Semantic search is not enabled" warning an explicit reindex prints.
+    nothing until it returned. Semantic search is always on (#1696), so the add
+    always runs the embedding pass.
     """
-    app_config = _stub_app_config(semantic_search_enabled=semantic_search_enabled)
+    app_config = _stub_app_config()
     monkeypatch.setattr(db_cmd, "ConfigManager", lambda: SimpleNamespace(config=app_config))
     steps: list[tuple[str, object]] = []
 
@@ -914,7 +911,7 @@ async def fake_report(project: str) -> None:
             "reindex",
             {
                 "search": True,
-                "embeddings": semantic_search_enabled,
+                "embeddings": True,
                 "full": False,
                 "project": "research",
             },

tests/indexing/test_deferred_embedding_resume.py

@@ -71,7 +71,6 @@ async def _semantic_repository(
     app_config: BasicMemoryConfig,
 ) -> SearchRepositoryBase:
     """Build the backend's search repository with semantic search on a stub provider."""
-    app_config.semantic_search_enabled = True
     if app_config.database_backend == DatabaseBackend.POSTGRES:
         async with db.scoped_session(session_maker) as session:
             try:

tests/test_config_env_overrides_not_persisted.py

@@ -38,7 +38,7 @@ def file_manager(config_home: Path) -> ConfigManager:
                 "projects": {"main": {"path": str(config_home / "main"), "mode": "local"}},
                 "default_project": "main",
                 "log_level": "INFO",
-                "semantic_search_enabled": False,
+                "format_on_save": False,
             }
         ),
         encoding="utf-8",
@@ -50,21 +50,21 @@ def test_project_add_keeps_file_values_under_env_override(
     file_manager: ConfigManager, config_home: Path, monkeypatch
 ):
     monkeypatch.setenv("BASIC_MEMORY_LOG_LEVEL", "DEBUG")
-    monkeypatch.setenv("BASIC_MEMORY_SEMANTIC_SEARCH_ENABLED", "true")
+    monkeypatch.setenv("BASIC_MEMORY_FORMAT_ON_SAVE", "true")
     monkeypatch.setenv("BASIC_MEMORY_CLI_OUTPUT_STYLE", "plain")
     _reset_config_cache()
 
     # The env values are in effect for this process.
     loaded = file_manager.load_config()
     assert loaded.log_level == "DEBUG"
-    assert loaded.semantic_search_enabled is True
+    assert loaded.format_on_save is True
 
     file_manager.add_project("leak", str(config_home / "leak"))
 
     written = _read_file(file_manager)
     assert "leak" in written["projects"]
     assert written["log_level"] == "INFO"
-    assert written["semantic_search_enabled"] is False
+    assert written["format_on_save"] is False
     # The file never had this key, so the env value must not appear either.
     assert "cli_output_style" not in written
 
@@ -101,7 +101,7 @@ def test_first_run_save_does_not_persist_env_values(config_home: Path, monkeypat
 
 def test_explicit_key_is_persisted_despite_env_override(file_manager: ConfigManager, monkeypatch):
     monkeypatch.setenv("BASIC_MEMORY_LOG_LEVEL", "DEBUG")
-    monkeypatch.setenv("BASIC_MEMORY_SEMANTIC_SEARCH_ENABLED", "true")
+    monkeypatch.setenv("BASIC_MEMORY_FORMAT_ON_SAVE", "true")
     _reset_config_cache()
 
     config = file_manager.load_config()
@@ -110,7 +110,7 @@ def test_explicit_key_is_persisted_despite_env_override(file_manager: ConfigMana
 
     written = _read_file(file_manager)
     assert written["log_level"] == "WARNING"
-    assert written["semantic_search_enabled"] is False
+    assert written["format_on_save"] is False
 
 
 def test_legacy_sync_env_keeps_the_file_legacy_value(config_home: Path, monkeypatch):