Skip to content

Commit 66c8577

Browse files
committed
ci: address review feedback on example app builds
1 parent 587bd01 commit 66c8577

1 file changed

Lines changed: 22 additions & 16 deletions

File tree

‎.github/workflows/build-example-apps.yml‎

Lines changed: 22 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,23 @@ on:
44
push:
55
branches:
66
- main
7-
paths-ignore:
8-
- docs/**
9-
- '**/*.md'
7+
paths:
8+
- '**'
9+
- '!docs/**'
10+
- '!**/*.md'
11+
- '!**/__tests__/**'
12+
- '!jest/**'
13+
- '!.github/workflows/**'
14+
- '.github/workflows/build-example-apps.yml'
1015
pull_request:
11-
paths-ignore:
12-
- docs/**
13-
- '**/*.md'
16+
paths:
17+
- '**'
18+
- '!docs/**'
19+
- '!**/*.md'
20+
- '!**/__tests__/**'
21+
- '!jest/**'
22+
- '!.github/workflows/**'
23+
- '.github/workflows/build-example-apps.yml'
1424
workflow_dispatch:
1525

1626
permissions:
@@ -21,8 +31,8 @@ concurrency:
2131
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
2232

2333
jobs:
24-
android:
25-
name: Android
34+
build-android:
35+
name: Build Android
2636
runs-on: ubuntu-latest
2737
timeout-minutes: 60
2838
steps:
@@ -44,16 +54,14 @@ jobs:
4454
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
4555
with:
4656
path: react-native-paper-example.apk
47-
key: android-${{ steps.fingerprint.outputs.fingerprint }}
57+
key: android-${{ steps.fingerprint.outputs.fingerprint }}-${{ hashFiles('.github/workflows/build-example-apps.yml') }}
4858

49-
# Repacking shells out to `apktool`, so this cannot be gated on the cache.
5059
- name: Setup JDK
5160
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
5261
with:
5362
distribution: temurin
5463
java-version: 17
5564

56-
# KSP in `expo-updates` runs out of the 512m metaspace that `expo prebuild` sets.
5765
- name: Build Android app
5866
if: steps.cache.outputs.cache-hit != 'true'
5967
working-directory: example
@@ -79,8 +87,8 @@ jobs:
7987
archive: false
8088
retention-days: 30
8189

82-
ios:
83-
name: iOS
90+
build-ios:
91+
name: Build iOS
8492
runs-on: macos-latest
8593
timeout-minutes: 60
8694
steps:
@@ -102,7 +110,7 @@ jobs:
102110
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
103111
with:
104112
path: react-native-paper-example.app
105-
key: ios-${{ steps.fingerprint.outputs.fingerprint }}
113+
key: ios-${{ steps.fingerprint.outputs.fingerprint }}-${{ hashFiles('.github/workflows/build-example-apps.yml') }}
106114

107115
- name: Build iOS app
108116
if: steps.cache.outputs.cache-hit != 'true'
@@ -120,7 +128,6 @@ jobs:
120128
ARCHS=arm64
121129
mv build/Build/Products/Release-iphonesimulator/ReactNativePaperExample.app ../../react-native-paper-example.app
122130
123-
# Repacking in place fails with ENOTEMPTY on an existing app directory.
124131
- name: Repack cached build
125132
if: steps.cache.outputs.cache-hit == 'true'
126133
working-directory: example
@@ -131,7 +138,6 @@ jobs:
131138
--source-app "$RUNNER_TEMP/cached.app" \
132139
--output ../react-native-paper-example.app
133140
134-
# `ditto` keeps the symlinks and executable bits a plain upload drops.
135141
- name: Archive app
136142
run: ditto -c -k --keepParent react-native-paper-example.app react-native-paper-example.app.zip
137143

0 commit comments

Comments
 (0)