From acb4de23e17e242b3b3df81a87148569fcadfc8f Mon Sep 17 00:00:00 2001 From: Tom Riglar Date: Thu, 22 Oct 2026 09:17:23 +0100 Subject: [PATCH] ci: skip promotion-pin on release-please PRs Release-please's release PR targets production but is not a promotion, so the Release-As pin check always failed on it (#230, #247). Co-Authored-By: Claude Opus 5.5 --- .github/workflows/cli-ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cli-ci.yml b/.github/workflows/cli-ci.yml index 3ec9ff9..fddf327 100644 --- a/.github/workflows/cli-ci.yml +++ b/.github/workflows/cli-ci.yml @@ -113,8 +113,11 @@ jobs: # # It has to be on a NORMAL commit, not the merge commit — release-please's # commit splitting is unreliable on merges. + # + # Release-please's own release PR also targets `production` but is not a + # promotion: it never carries a pin, so the check would always fail on it. promotion-pin: - if: github.event_name == 'pull_request' && github.base_ref == 'production' + if: github.event_name == 'pull_request' && github.base_ref == 'production' && !startsWith(github.head_ref, 'release-please--') runs-on: ubuntu-latest steps: - uses: actions/checkout@v7