From 78657c58b54d0a5cf67faed6baae7acafdbd95b3 Mon Sep 17 00:00:00 2001 From: Eric Mann Date: Fri, 9 Oct 2026 13:24:03 -0700 Subject: [PATCH] Drop a PHPStan ignore that 2.3.0 no longer needs Core's trunk moved to PHPStan 2.3.0, which no longer reports method.impossibleType on the assertion in the memzero test. The tests are analyzed inside wordpress-develop, where an unmatched ignore is an error. --- tests/phpunit/test-wp-secrets-memzero.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/phpunit/test-wp-secrets-memzero.php b/tests/phpunit/test-wp-secrets-memzero.php index 3df026b..350a3fc 100644 --- a/tests/phpunit/test-wp-secrets-memzero.php +++ b/tests/phpunit/test-wp-secrets-memzero.php @@ -18,7 +18,7 @@ public function test_leaves_non_string_values_untouched(): void { wp_secrets_memzero( $value ); // @phpstan-ignore argument.type (Intentionally passing a non-string value.) - $this->assertSame( 42, $value ); // @phpstan-ignore method.impossibleType (The by-reference parameter is documented as a string; this checks a non-string comes back untouched.) + $this->assertSame( 42, $value ); } public function test_leaves_an_empty_string_untouched(): void {