fix: bugbot findings

Author: isaacs

packages/bun/test/integrations/bunserver.test.ts

@@ -1459,8 +1459,14 @@ describe('Bun Serve Integration', () => {
   describe('sessions', () => {
     type SessionCounts = Omit<AggregationCounts, 'started'>;
 
-    function setupSessionClient(options?: BunOptions): { client: SentryCore.Client; sessions: SessionCounts[] } {
+    function setupSessionClient(options?: BunOptions): {
+      client: SentryCore.Client;
+      sessions: SessionCounts[];
+      firstSession: Promise<void>;
+    } {
       const sessions: SessionCounts[] = [];
+      let resolveFirstSession: () => void;
+      const firstSession = new Promise<void>(resolve => (resolveFirstSession = resolve));
       setupClient({
         release: '1.0.0',
         integrations: [bunServerIntegration()],
@@ -1474,12 +1480,13 @@ describe('Bun Serve Integration', () => {
                   .aggregates) {
                   sessions.push(counts);
                 }
+                resolveFirstSession();
               }
             });
             return SentryCore.resolvedSyncPromise({});
           }),
       });
-      return { client: SentryCore.getClient()!, sessions };
+      return { client: SentryCore.getClient()!, sessions, firstSession };
     }
 
     test('records an exited session for a successful request', async () => {
@@ -1533,6 +1540,35 @@ describe('Bun Serve Integration', () => {
       expect(sessions).toEqual([{ exited: 0, errored: 0, crashed: 1 }]);
     });
 
+    test.each([
+      ['when tracing is enabled', {}],
+      ['when tracing is disabled', { tracesSampleRate: undefined }],
+    ] as const)('records a crashed session when a streamed response source fails %s', async (_label, options) => {
+      const { client, sessions } = setupSessionClient(options);
+      let controller: ReadableStreamDefaultController<Uint8Array>;
+      const source = new ReadableStream<Uint8Array>({
+        start(value) {
+          controller = value;
+        },
+      });
+      const server = Bun.serve({
+        port,
+        fetch: () => new Response(source, { headers: { 'content-type': 'text/event-stream' } }),
+      });
+      try {
+        const response = await server.fetch(new Request(`http://localhost:${port}/events`));
+        const error = new Error('stream interrupted');
+        const text = response.text();
+        controller!.error(error);
+        await expect(text).rejects.toBe(error);
+      } finally {
+        await server.stop(true);
+      }
+      await client.flush();
+
+      expect(sessions).toEqual([{ exited: 0, errored: 0, crashed: 1 }]);
+    });
+
     test('records sessions for OPTIONS and HEAD requests', async () => {
       const { client, sessions } = setupSessionClient();
       const server = Bun.serve({ port, fetch: () => new Response('ok') });
@@ -1578,7 +1614,7 @@ describe('Bun Serve Integration', () => {
     });
 
     test('sends the session aggregate after sessionFlushingDelayMS', async () => {
-      const { sessions } = setupSessionClient({
+      const { sessions, firstSession } = setupSessionClient({
         integrations: [bunServerIntegration({ sessionFlushingDelayMS: 50 })],
       });
       const server = Bun.serve({ port, fetch: () => new Response('ok') });
@@ -1588,8 +1624,16 @@ describe('Bun Serve Integration', () => {
         await server.stop(true);
       }
 
-      // No flush here. With the default 60s delay, no session arrives in time.
-      await new Promise(resolve => setTimeout(resolve, 200));
+      // No flush here. The timeout only bounds a failure. With the default 60s delay, no session
+      // arrives within it.
+      let timeoutId: ReturnType<typeof setTimeout> | undefined;
+      const timedOut = new Promise<'timed out'>(resolve => {
+        timeoutId = setTimeout(() => resolve('timed out'), 2_000);
+      });
+      const result = await Promise.race([firstSession.then(() => 'sent' as const), timedOut]);
+      clearTimeout(timeoutId);
+
+      expect(result).toBe('sent');
       expect(sessions).toEqual([{ exited: 1, errored: 0, crashed: 0 }]);
     });