Repository navigation
Commit ce82586
authored
Move rake development dependency to Gemfile (#603)
## All PRs:
* [x] Has tests
* [ ] Documentation updated
Move `rake` from `secure_headers.gemspec` into the alphabetized `:test`
group in `Gemfile`. This fixes the `Gemspec/DevelopmentDependencies`
offense enabled by `rubocop-github` 0.29.0, which caused the Ruby 3.4
and 4.0 jobs in [the failing main
build](https://github.com/github/secure_headers/actions/runs/37043211037)
to fail.
The runtime `cgi` dependency is unchanged. No dependency pins, lockfile,
or CI configuration changes are included. Documentation updates and new
tests are not applicable to this development-dependency relocation; the
existing suite and lint checks cover the change.
Validation used `export RBENV_VERSION=4.0.5`, Bundler 4.0.19, RuboCop
1.91.0, and `rubocop-github` 0.29.0:
| Command | Result |
| --- | --- |
| `bundle exec rubocop --only Gemspec/DevelopmentDependencies
secure_headers.gemspec` (before the fix) | Failed as expected with the
reported line-34 offense |
| `bundle exec rubocop` (after the fix) | Passed: 48 files, no offenses
|
| `bundle exec rspec spec` | Passed: 322 examples, 0 failures |
| `bundle exec rake --version` | Passed: rake 13.4.2 remains available
through Bundler |
| `bundle exec rake -T` | Passed: project tasks load successfully |
| `git diff --check` | Passed |
RSpec emitted a nonblocking Coveralls/SimpleCov deprecation warning.
Other Ruby matrix versions were not run locally.
## Adding a new header
Generally, adding a new header is always OK.
* Is the header supported by any user agent? If so, which? N/A; no
header added.
* What does it do? N/A.
* What are the valid values for the header? N/A.
* Where does the specification live? N/A.
## Adding a new CSP directive
* Is the directive supported by any user agent? If so, which? N/A; no
directive added.
* What does it do? N/A.
* What are the valid values for the directive? N/A.2 files changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
35 | 33 | | |
0 commit comments