fix: replace read-only notices when rebuilding into the same output

Author: iamnbutler

.github/workflows/check.yml

@@ -33,3 +33,8 @@ jobs:
           node-version: 24
       # Unsigned: signing belongs to each embedding app.
       - run: node dist/build.js --out build --scratch .build/native
+      # Embedders rebuild into the same output; notices from other sources must survive.
+      - run: |
+          mkdir -p build/Licenses/embedder && echo kept > build/Licenses/embedder/NOTICE
+          node dist/build.js --out build --scratch .build/native
+          test "$(cat build/Licenses/embedder/NOTICE)" = kept

dist/build.js

@@ -134,8 +134,11 @@ const notices = (source, identity) => {
     if (!files.length)
         throw new Error(`The native dependency ${identity} has no license file`);
     mkdirSync(join(licenses, identity), { recursive: true });
-    for (const name of files)
+    for (const name of files) {
+        // Checked-out notices are read-only and copies keep that mode, so replace each one.
+        rmSync(join(licenses, identity, name), { force: true });
         copyFileSync(join(source, name), join(licenses, identity, name));
+    }
 };
 notices(root, "desktop-tools");
 for (const { identity } of resolved.pins) {

src/build.ts

@@ -139,7 +139,11 @@ const notices = (source: string, identity: string) => {
 	);
 	if (!files.length) throw new Error(`The native dependency ${identity} has no license file`);
 	mkdirSync(join(licenses, identity), { recursive: true });
-	for (const name of files) copyFileSync(join(source, name), join(licenses, identity, name));
+	for (const name of files) {
+		// Checked-out notices are read-only and copies keep that mode, so replace each one.
+		rmSync(join(licenses, identity, name), { force: true });
+		copyFileSync(join(source, name), join(licenses, identity, name));
+	}
 };
 notices(root, "desktop-tools");
 for (const { identity } of resolved.pins) {