From 94bac966665a324f754b8382df186ef4ff75ba12 Mon Sep 17 00:00:00 2001 From: Sravan1011 Date: Fri, 17 Apr 2026 00:20:31 +0530 Subject: [PATCH] fix: add verification step and update headers for change_issue_type --- .../samples/adk_triaging_agent/agent.py | 21 +++++++++++++++++++ .../samples/adk_triaging_agent/utils.py | 3 ++- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/contributing/samples/adk_triaging_agent/agent.py b/contributing/samples/adk_triaging_agent/agent.py index cec5805f573..43c800d6b86 100644 --- a/contributing/samples/adk_triaging_agent/agent.py +++ b/contributing/samples/adk_triaging_agent/agent.py @@ -240,6 +240,27 @@ def change_issue_type(issue_number: int, issue_type: str) -> dict[str, Any]: except requests.exceptions.RequestException as e: return error_response(f"Error: {e}") + # Verify the type was actually updated + try: + updated_issue = get_request(url) + actual_type = updated_issue.get("type") + if actual_type is None: + return error_response( + f"Issue type update for issue #{issue_number} could not be verified:" + " 'type' field not present in API response. The API may not support" + " issue types for this repository." + ) + actual_type_name = actual_type.get("name", "") + if actual_type_name.lower() != issue_type.lower(): + return error_response( + f"Issue type update for issue #{issue_number} failed silently:" + f" expected '{issue_type}', but got '{actual_type_name}'." + ) + except requests.exceptions.RequestException as e: + return error_response( + f"Issue type PATCH succeeded but verification GET failed: {e}" + ) + return {"status": "success", "message": response, "issue_type": issue_type} diff --git a/contributing/samples/adk_triaging_agent/utils.py b/contributing/samples/adk_triaging_agent/utils.py index 8c5aa9b19dc..76510b7334b 100644 --- a/contributing/samples/adk_triaging_agent/utils.py +++ b/contributing/samples/adk_triaging_agent/utils.py @@ -19,7 +19,8 @@ headers = { "Authorization": f"token {GITHUB_TOKEN}", - "Accept": "application/vnd.github.v3+json", + "Accept": "application/vnd.github+json", + "X-GitHub-Api-Version": "2022-11-28", }