Skip to content

Commit 0cc87ec

Browse files
cspath1cursoragent
andauthored
prepare 2.3.1 release (#252)
Bump version and changelog for skip-comment fix, flag API pagination, and CI/release workflow updates. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > **Prepares the 2.3.1 release** by bumping `internal/version` to **2.3.1** and adding a **2.3.1** section to `CHANGELOG.md` (fixes and CI/release notes that ship with this tag). > > Docs and the **`docker/` composite action** now pin the default and example **`dockerImage`** / action ref from **2.3.0 → 2.3.1** in `README.md` and `docker/action.yml`. > > The changelog records what 2.3.1 includes: corrected **`skip-comment`** polarity, LaunchDarkly flag listing on API **`20240415`** with pagination, Docker Hub publish credentials via **`release-secrets`/SSM**, and fork PR unit tests on **`pull_request`** instead of **`pull_request_target`**. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d75922a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent d8b3a47 commit 0cc87ec

4 files changed

Lines changed: 15 additions & 5 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,20 @@
44

55
### Changed
66

7+
### Fixed
8+
9+
## 2.3.1
10+
11+
### Added
12+
13+
### Changed
14+
715
- Docker Hub image publish workflow loads credentials via `release-secrets` / SSM (same as other public LD images) instead of repo `DOCKERHUB_*` secrets
16+
- Run fork pull request unit tests on the unprivileged `pull_request` workflow instead of `pull_request_target`
817

918
### Fixed
1019

20+
- `skip-comment` input had inverted behavior in v2.3.0 (`true` still posted PR comments; `false` skipped)
1121
- Update flag listing from deprecated REST API version `20220603` to the current version,
1222
[`20240415`](https://launchdarkly.com/docs/guides/api/api-migration-guide), including pagination support
1323
for active and archived flags

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@ jobs:
109109
- name: Find flags
110110
id: find-flags
111111
# Pin to a release that includes the docker/ entry point and published image (see changelog).
112-
uses: launchdarkly/find-code-references-in-pull-request/docker@v2.3.0
112+
uses: launchdarkly/find-code-references-in-pull-request/docker@v2.3.1
113113
with:
114114
project-key: default
115115
environment-key: production
116116
access-token: ${{ secrets.LD_ACCESS_TOKEN }}
117117
repo-token: ${{ secrets.GITHUB_TOKEN }}
118-
dockerImage: your.registry.example/launchdarkly/find-code-references-in-pull-request:2.3.0
118+
dockerImage: your.registry.example/launchdarkly/find-code-references-in-pull-request:2.3.1
119119
```
120120

121121
This entry point requires a Docker CLI on the runner (included on GitHub-hosted `ubuntu-*` runners). Existing workflows that use the root Action do not need to change.

‎docker/action.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,12 @@ inputs:
5555
description: >-
5656
Container image to run. Defaults to the public Docker Hub runtime image.
5757
Set this to your mirrored/proxy image (for example
58-
your.registry.example/launchdarkly/find-code-references-in-pull-request:2.3.0).
58+
your.registry.example/launchdarkly/find-code-references-in-pull-request:2.3.1).
5959
Authenticate to private registries with docker/login-action (or equivalent)
6060
in a prior step. Requires a runner with a Docker CLI (GitHub-hosted
6161
ubuntu-* runners include one).
6262
required: false
63-
default: "launchdarkly/find-code-references-in-pull-request:2.3.0"
63+
default: "launchdarkly/find-code-references-in-pull-request:2.3.1"
6464

6565
outputs:
6666
any-modified:

‎internal/version/version.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
package version
22

3-
const Version = "2.3.0"
3+
const Version = "2.3.1"

0 commit comments

Comments
 (0)