-
Notifications
You must be signed in to change notification settings - Fork 625
Expand file tree
/
Copy pathproxy.test.ts
More file actions
865 lines (750 loc) · 27.6 KB
/
Copy pathproxy.test.ts
File metadata and controls
865 lines (750 loc) · 27.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
import { MCPProxy } from '../proxy'
import { OpenAPIV3 } from 'openapi-types'
import { HttpClient } from '../../client/http-client'
import type { Transport } from '@modelcontextprotocol/sdk/shared/transport.js'
import { describe, expect, it, beforeEach, afterEach, vi } from 'vitest'
// Mock the dependencies
vi.mock('../../client/http-client')
vi.mock('@modelcontextprotocol/sdk/server/index.js')
describe('MCPProxy', () => {
let proxy: MCPProxy
let mockOpenApiSpec: OpenAPIV3.Document
beforeEach(() => {
// Reset all mocks
vi.clearAllMocks()
// Setup minimal OpenAPI spec for testing
mockOpenApiSpec = {
openapi: '3.0.0',
servers: [{ url: 'http://localhost:3000' }],
info: {
title: 'Test API',
version: '1.0.0',
},
paths: {
'/test': {
get: {
operationId: 'getTest',
responses: {
'200': {
description: 'Success',
},
},
},
},
},
}
proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
})
describe('listTools handler', () => {
it('should return converted tools from OpenAPI spec', async () => {
const server = (proxy as any).server
const listToolsHandler = server.setRequestHandler.mock.calls[0].filter((x: unknown) => typeof x === 'function')[0]
const result = await listToolsHandler()
expect(result).toHaveProperty('tools')
expect(Array.isArray(result.tools)).toBe(true)
})
it('should truncate tool names exceeding 64 characters', async () => {
// Setup OpenAPI spec with long tool names
mockOpenApiSpec.paths = {
'/test': {
get: {
operationId: 'a'.repeat(65),
responses: {
'200': {
description: 'Success'
}
}
}
}
}
proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
const server = (proxy as any).server
const listToolsHandler = server.setRequestHandler.mock.calls[0].filter((x: unknown) => typeof x === 'function')[0];
const result = await listToolsHandler()
expect(result.tools[0].name.length).toBeLessThanOrEqual(64)
})
})
describe('callTool handler', () => {
it('should execute operation and return formatted response', async () => {
// Mock HttpClient response
const mockResponse = {
data: { message: 'success' },
status: 200,
headers: new Headers({
'content-type': 'application/json',
}),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
// Set up the openApiLookup with our test operation
;(proxy as any).openApiLookup = {
'API-getTest': {
operationId: 'getTest',
responses: { '200': { description: 'Success' } },
method: 'get',
path: '/test',
},
}
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
const result = await callToolHandler({
params: {
name: 'API-getTest',
arguments: {},
},
})
expect(result).toEqual({
content: [
{
type: 'text',
text: JSON.stringify({ message: 'success' }),
},
],
})
})
it('should throw error for non-existent operation', async () => {
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
await expect(
callToolHandler({
params: {
name: 'nonExistentMethod',
arguments: {},
},
}),
).rejects.toThrow('Method nonExistentMethod not found')
})
it('should handle tool names exceeding 64 characters', async () => {
// Mock HttpClient response
const mockResponse = {
data: { message: 'success' },
status: 200,
headers: new Headers({
'content-type': 'application/json'
})
};
(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse);
// Set up the openApiLookup with a long tool name
const longToolName = 'a'.repeat(65)
const truncatedToolName = longToolName.slice(0, 64)
;(proxy as any).openApiLookup = {
[truncatedToolName]: {
operationId: longToolName,
responses: { '200': { description: 'Success' } },
method: 'get',
path: '/test'
}
};
const server = (proxy as any).server;
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function');
const callToolHandler = handlers[1];
const result = await callToolHandler({
params: {
name: truncatedToolName,
arguments: {}
}
})
expect(result).toEqual({
content: [
{
type: 'text',
text: JSON.stringify({ message: 'success' })
}
]
})
})
})
describe('getContentType', () => {
it('should return correct content type for different headers', () => {
const getContentType = (proxy as any).getContentType.bind(proxy)
expect(getContentType(new Headers({ 'content-type': 'text/plain' }))).toBe('text')
expect(getContentType(new Headers({ 'content-type': 'application/json' }))).toBe('text')
expect(getContentType(new Headers({ 'content-type': 'image/jpeg' }))).toBe('image')
expect(getContentType(new Headers({ 'content-type': 'application/octet-stream' }))).toBe('binary')
expect(getContentType(new Headers())).toBe('binary')
})
})
describe('parseHeadersFromEnv', () => {
const originalEnv = process.env
beforeEach(() => {
process.env = { ...originalEnv }
})
afterEach(() => {
process.env = originalEnv
})
it('should parse valid JSON headers from env', () => {
process.env.OPENAPI_MCP_HEADERS = JSON.stringify({
Authorization: 'Bearer token123',
'X-Custom-Header': 'test',
})
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {
Authorization: 'Bearer token123',
'X-Custom-Header': 'test',
},
}),
expect.anything(),
)
})
it('should return empty object when env var is not set', () => {
delete process.env.OPENAPI_MCP_HEADERS
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {},
}),
expect.anything(),
)
})
it('should return empty object and warn on invalid JSON', () => {
const consoleSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
process.env.OPENAPI_MCP_HEADERS = 'invalid json'
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {},
}),
expect.anything(),
)
expect(consoleSpy).toHaveBeenCalledWith('Failed to parse OPENAPI_MCP_HEADERS environment variable:', expect.any(Error))
consoleSpy.mockRestore()
})
it('should return empty object and warn on non-object JSON', () => {
const consoleSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
process.env.OPENAPI_MCP_HEADERS = '"string"'
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {},
}),
expect.anything(),
)
expect(consoleSpy).toHaveBeenCalledWith('OPENAPI_MCP_HEADERS environment variable must be a JSON object, got:', 'string')
consoleSpy.mockRestore()
})
it('should use NOTION_TOKEN when OPENAPI_MCP_HEADERS is not set', () => {
delete process.env.OPENAPI_MCP_HEADERS
process.env.NOTION_TOKEN = 'ntn_test_token_123'
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
// Notion-Version is no longer hardcoded here; it is sourced per-operation
// from the OpenAPI spec by HttpClient.
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {
'Authorization': 'Bearer ntn_test_token_123',
},
}),
expect.anything(),
)
})
it('should prioritize OPENAPI_MCP_HEADERS over NOTION_TOKEN when both are set', () => {
process.env.OPENAPI_MCP_HEADERS = JSON.stringify({
Authorization: 'Bearer custom_token',
'Custom-Header': 'custom_value',
})
process.env.NOTION_TOKEN = 'ntn_test_token_123'
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {
Authorization: 'Bearer custom_token',
'Custom-Header': 'custom_value',
},
}),
expect.anything(),
)
})
it('should return empty object when neither OPENAPI_MCP_HEADERS nor NOTION_TOKEN are set', () => {
delete process.env.OPENAPI_MCP_HEADERS
delete process.env.NOTION_TOKEN
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {},
}),
expect.anything(),
)
})
it('should use NOTION_TOKEN when OPENAPI_MCP_HEADERS is empty object', () => {
process.env.OPENAPI_MCP_HEADERS = '{}'
process.env.NOTION_TOKEN = 'ntn_test_token_123'
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {
'Authorization': 'Bearer ntn_test_token_123',
},
}),
expect.anything(),
)
})
})
describe('explicit headers (per-request token passthrough)', () => {
const originalEnv = process.env
beforeEach(() => {
process.env = { ...originalEnv }
})
afterEach(() => {
process.env = originalEnv
})
it('uses explicit headers instead of the environment when provided', () => {
process.env.NOTION_TOKEN = 'ntn_env_token_should_be_ignored'
const headers = {
Authorization: 'Bearer ntn_per_request_token',
'Notion-Version': '2025-09-03',
}
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec, headers)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({ headers }),
expect.anything(),
)
})
it('falls back to the environment when headers are omitted', () => {
process.env.NOTION_TOKEN = 'ntn_env_token_123'
delete process.env.OPENAPI_MCP_HEADERS
const proxy = new MCPProxy('test-proxy', mockOpenApiSpec)
expect(HttpClient).toHaveBeenCalledWith(
expect.objectContaining({
headers: {
Authorization: 'Bearer ntn_env_token_123',
},
}),
expect.anything(),
)
})
})
describe('connect', () => {
it('should connect to transport', async () => {
const mockTransport = {} as Transport
await proxy.connect(mockTransport)
const server = (proxy as any).server
expect(server.connect).toHaveBeenCalledWith(mockTransport)
})
})
describe('string-encoded object params deserialized in handler (issue #208)', () => {
let callToolHandler: Function
beforeEach(() => {
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls
.flatMap((x: unknown[]) => x)
.filter((x: unknown) => typeof x === 'function')
callToolHandler = handlers[1]
})
it('should handle notion-create-a-page parent provided as a JSON string', async () => {
const mockResponse = {
data: { id: 'new-page-id' },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'notion-create-a-page': {
operationId: 'notion-create-a-page',
responses: { '200': { description: 'Success' } },
method: 'post',
path: '/pages',
},
}
// Claude Desktop ≥ v1.1.3189 sends object params as JSON strings
const parentAsString = JSON.stringify({ database_id: 'abc123' })
// Should not throw in this handler-level test
await expect(
callToolHandler({
params: {
name: 'notion-create-a-page',
arguments: { parent: parentAsString },
},
}),
).resolves.toBeDefined()
// deserializeParams should have converted it back to an object
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
expect.objectContaining({
parent: { database_id: 'abc123' },
}),
)
})
it('should still work when notion-create-a-page parent is already an object (backward compatible)', async () => {
const mockResponse = {
data: { id: 'new-page-id' },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'notion-create-a-page': {
operationId: 'notion-create-a-page',
responses: { '200': { description: 'Success' } },
method: 'post',
path: '/pages',
},
}
await expect(
callToolHandler({
params: {
name: 'notion-create-a-page',
arguments: { parent: { database_id: 'abc123' } },
},
}),
).resolves.toBeDefined()
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
expect.objectContaining({
parent: { database_id: 'abc123' },
}),
)
})
it('should handle notion-update-page data provided as a JSON string', async () => {
const mockResponse = {
data: { id: 'updated-page-id' },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'notion-update-page': {
operationId: 'notion-update-page',
responses: { '200': { description: 'Success' } },
method: 'patch',
path: '/pages/{page_id}',
},
}
const dataAsString = JSON.stringify({ properties: { Status: { select: { name: 'Done' } } } })
await expect(
callToolHandler({
params: {
name: 'notion-update-page',
arguments: { data: dataAsString },
},
}),
).resolves.toBeDefined()
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
expect.objectContaining({
data: { properties: { Status: { select: { name: 'Done' } } } },
}),
)
})
it('should call deserializeParams and convert string to object before executeOperation', async () => {
const mockResponse = {
data: { success: true },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'notion-move-pages': {
operationId: 'notion-move-pages',
responses: { '200': { description: 'Success' } },
method: 'post',
path: '/pages/move',
},
}
const newParentAsString = JSON.stringify({ page_id: 'parent-page-id' })
await callToolHandler({
params: {
name: 'notion-move-pages',
arguments: { new_parent: newParentAsString },
},
})
// Verify executeOperation received the deserialized object, not the string
const callArgs = (HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mock.calls[0]
const passedParams = callArgs[1]
expect(typeof passedParams.new_parent).not.toBe('string')
expect(passedParams.new_parent).toEqual({ page_id: 'parent-page-id' })
})
})
describe('double-serialization fix (issue #176)', () => {
it('should deserialize stringified JSON object parameters', async () => {
// Mock HttpClient response
const mockResponse = {
data: { message: 'success' },
status: 200,
headers: new Headers({
'content-type': 'application/json',
}),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
// Set up the openApiLookup with our test operation
;(proxy as any).openApiLookup = {
'API-updatePage': {
operationId: 'updatePage',
responses: { '200': { description: 'Success' } },
method: 'patch',
path: '/pages/{page_id}',
},
}
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
// Simulate double-serialized parameters (the bug from issue #176)
const stringifiedData = JSON.stringify({
page_id: 'test-page-id',
command: 'update_properties',
properties: { Status: 'Done' },
})
await callToolHandler({
params: {
name: 'API-updatePage',
arguments: {
data: stringifiedData, // This would normally fail with "Expected object, received string"
},
},
})
// Verify that the parameters were deserialized before being passed to executeOperation
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
{
data: {
page_id: 'test-page-id',
command: 'update_properties',
properties: { Status: 'Done' },
},
},
)
})
it('should handle nested stringified JSON parameters', async () => {
const mockResponse = {
data: { success: true },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'API-createPage': {
operationId: 'createPage',
responses: { '200': { description: 'Success' } },
method: 'post',
path: '/pages',
},
}
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
// Nested stringified object
const nestedData = JSON.stringify({
parent: JSON.stringify({ page_id: 'parent-page-id' }),
})
await callToolHandler({
params: {
name: 'API-createPage',
arguments: {
data: nestedData,
},
},
})
// Verify nested objects were also deserialized
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
{
data: {
parent: { page_id: 'parent-page-id' },
},
},
)
})
it('should deserialize JSON string items within an array parameter', async () => {
const mockResponse = {
data: { id: 'new-page-id' },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'API-appendBlockChildren': {
operationId: 'appendBlockChildren',
responses: { '200': { description: 'Success' } },
method: 'patch',
path: '/blocks/{block_id}/children',
},
}
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
// Claude Desktop sends each array item as a JSON string
const block1 = JSON.stringify({ object: 'block', type: 'paragraph', paragraph: { rich_text: [{ type: 'text', text: { content: 'Hello' } }] } })
const block2 = JSON.stringify({ object: 'block', type: 'heading_1', heading_1: { rich_text: [{ type: 'text', text: { content: 'Title' } }] } })
await callToolHandler({
params: {
name: 'API-appendBlockChildren',
arguments: {
children: [block1, block2],
},
},
})
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
{
children: [
{ object: 'block', type: 'paragraph', paragraph: { rich_text: [{ type: 'text', text: { content: 'Hello' } }] } },
{ object: 'block', type: 'heading_1', heading_1: { rich_text: [{ type: 'text', text: { content: 'Title' } }] } },
],
},
)
})
it('should pass through an array of proper objects unchanged', async () => {
const mockResponse = {
data: { id: 'new-page-id' },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'API-appendBlockChildren': {
operationId: 'appendBlockChildren',
responses: { '200': { description: 'Success' } },
method: 'patch',
path: '/blocks/{block_id}/children',
},
}
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
const block1 = { object: 'block', type: 'paragraph' }
const block2 = { object: 'block', type: 'heading_1' }
await callToolHandler({
params: {
name: 'API-appendBlockChildren',
arguments: {
children: [block1, block2],
},
},
})
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
{ children: [block1, block2] },
)
})
it('should handle a mixed array with both string items and object items', async () => {
const mockResponse = {
data: { success: true },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'API-appendBlockChildren': {
operationId: 'appendBlockChildren',
responses: { '200': { description: 'Success' } },
method: 'patch',
path: '/blocks/{block_id}/children',
},
}
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
const blockAsString = JSON.stringify({ object: 'block', type: 'paragraph' })
const blockAsObject = { object: 'block', type: 'heading_1' }
await callToolHandler({
params: {
name: 'API-appendBlockChildren',
arguments: {
children: [blockAsString, blockAsObject],
},
},
})
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
{
children: [
{ object: 'block', type: 'paragraph' },
{ object: 'block', type: 'heading_1' },
],
},
)
})
it('should preserve non-JSON string items within arrays', async () => {
const mockResponse = {
data: { success: true },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'API-search': {
operationId: 'search',
responses: { '200': { description: 'Success' } },
method: 'post',
path: '/search',
},
}
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
await callToolHandler({
params: {
name: 'API-search',
arguments: {
tags: ['hello', 'world', '{ not valid json }'],
},
},
})
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
{ tags: ['hello', 'world', '{ not valid json }'] },
)
})
it('should preserve non-JSON string parameters', async () => {
const mockResponse = {
data: { success: true },
status: 200,
headers: new Headers({ 'content-type': 'application/json' }),
}
;(HttpClient.prototype.executeOperation as ReturnType<typeof vi.fn>).mockResolvedValue(mockResponse)
;(proxy as any).openApiLookup = {
'API-search': {
operationId: 'search',
responses: { '200': { description: 'Success' } },
method: 'post',
path: '/search',
},
}
const server = (proxy as any).server
const handlers = server.setRequestHandler.mock.calls.flatMap((x: unknown[]) => x).filter((x: unknown) => typeof x === 'function')
const callToolHandler = handlers[1]
await callToolHandler({
params: {
name: 'API-search',
arguments: {
query: 'hello world', // Regular string, should NOT be parsed
filter: '{ not valid json }', // Looks like JSON but isn't valid
},
},
})
// Verify that non-JSON strings are preserved as-is
expect(HttpClient.prototype.executeOperation).toHaveBeenCalledWith(
expect.anything(),
{
query: 'hello world',
filter: '{ not valid json }',
},
)
})
})
})
import { Server } from '@modelcontextprotocol/sdk/server/index.js'
import { getPackageVersion } from '../../../version'
describe('serverInfo version (issue #310)', () => {
let spec: OpenAPIV3.Document
beforeEach(() => {
vi.clearAllMocks()
spec = {
openapi: '3.0.0',
servers: [{ url: 'http://localhost:3000' }],
info: { title: 'Test API', version: '9.9.9' },
paths: {},
}
})
it('reports the package.json version to MCP clients, not the hardcoded 1.0.0', () => {
new MCPProxy('Notion API', spec)
const initArg = (Server as unknown as { mock: { calls: unknown[][] } }).mock.calls.at(-1)![0] as {
name: string
version: string
}
expect(initArg.version).toBe(getPackageVersion())
expect(initArg.version).not.toBe('1.0.0')
})
})