Skip to content

Commit c9bb8c3

Browse files
committed
fix comment: the worker half is uncovered, not delegated elsewhere
1 parent 052c73b commit c9bb8c3

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

tests/js-native-api/test_instance_data/testInstanceDataTeardown.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
11
'use strict';
22

33
// The delete hook passed to napi_set_instance_data only runs when the
4-
// environment goes away, so observing it takes a child process. Upstream also
5-
// runs this in a worker thread; worker threads are a Node.js runtime API, so
6-
// that variant belongs to the node-api side of the suite.
4+
// environment goes away, so observing it takes a child process.
5+
//
6+
// Upstream also runs the whole test body in a worker thread, which additionally
7+
// covers instance data being per-environment and the hook running when a
8+
// secondary environment is torn down. Starting a worker is not expressible in
9+
// portable ECMAScript, so that half waits on the harness capability proposed in
10+
// https://github.com/nodejs/node-api-cts/pull/67.
711
if (!runtimeFeatures.spawn) {
812
skipTest();
913
}

0 commit comments

Comments
 (0)