Skip to content

Commit cd0fa5c

Browse files
committed
fix(v8): concatenate adjacent strings in V8 DEPS files
These follow Python string concatenation rules.
1 parent 4b5695c commit cd0fa5c

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎lib/update-v8/deps.js‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ async function readDeps(nodeDir) {
3131
const depsStr = await fs.readFile(path.join(nodeDir, 'deps/v8/DEPS'), 'utf8');
3232
const start = depsStr.indexOf('deps = {');
3333
const end = depsStr.indexOf('\n}', start) + 2;
34-
const depsDeclaration = depsStr.substring(start, end).replace(/^ *#.*/gm, '');
34+
const depsDeclaration = depsStr.substring(start, end)
35+
.replace(/^ *#.*/gm, '')
36+
// Join adjacent string literals
37+
.replace(/'\s*\n\s*'/g, '');
3538
const Var = () => chromiumGit; // eslint-disable-line no-unused-vars
3639
let deps;
3740
eval(depsDeclaration); // eslint-disable-line no-eval

0 commit comments

Comments
 (0)