You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #4222 (see this comment for context) — KeyboardShortcutModal.jsx has drifted from what's actually wired up in keymaps.js. A few known discrepancies:
Advertised but not implemented:
The modal lists {Ctrl/Cmd}+H for "Replace," but there's no replace command wired up anywhere in keymaps.js. Worth deciding: implement it (CodeMirror 6's search panel already supports replace, just needs to be exposed on this shortcut), or remove the claim from the modal if it's not planned.
Shift-Ctrl-D (Shift-Cmd-D on Mac) — duplicate line, and Ctrl-Up/Down (Ctrl-Alt-Up/Down on Mac) — scroll without moving cursor, both pending in a follow-up PR.
Proposal
Decide the fate of the Replace shortcut (implement vs. remove from modal).
Add entries to KeyboardShortcutModal.jsx for the shortcuts above.
Follow-up to #4222 (see this comment for context) —
KeyboardShortcutModal.jsxhas drifted from what's actually wired up inkeymaps.js. A few known discrepancies:Advertised but not implemented:
{Ctrl/Cmd}+Hfor "Replace," but there's noreplacecommand wired up anywhere inkeymaps.js. Worth deciding: implement it (CodeMirror 6's search panel already supports replace, just needs to be exposed on this shortcut), or remove the claim from the modal if it's not planned.Implemented but not advertised:
Ctrl-Shift-Up/Down(Cmd-Ctrl-Up/Downon Mac) — move line up/down, added in Fix Ctrl+Shift+Up/Down no longer moving lines #4250.Shift-Ctrl-D(Shift-Cmd-Don Mac) — duplicate line, andCtrl-Up/Down(Ctrl-Alt-Up/Downon Mac) — scroll without moving cursor, both pending in a follow-up PR.Proposal
KeyboardShortcutModal.jsxfor the shortcuts above.Happy to take this on.