drop target=_blank from manage links except where leaving loses form state

Author: JacobCoffee

apps/sponsors/templates/sponsors/manage/asset_browser.html

@@ -106,7 +106,7 @@ <h2>
                         <td style="font-size:12px;color:#555;max-width:250px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;">
                             {% if asset.has_value %}
                                 {% if asset.is_file %}
-                                <a href="{{ asset.value.url }}" target="_blank" rel="noopener noreferrer" style="color:#3776ab;text-decoration:none;">{{ asset.value.name|truncatechars:40 }}</a>
+                                <a href="{{ asset.value.url }}" style="color:#3776ab;text-decoration:none;">{{ asset.value.name|truncatechars:40 }}</a>
                                 {% else %}
                                 {{ asset.value|truncatechars:80 }}
                                 {% endif %}

apps/sponsors/templates/sponsors/manage/composer.html

@@ -647,7 +647,7 @@ <h2>Select a Sponsor</h2>
                     <ul style="margin:6px 0 0;">
                     {% for dup in form.duplicate_sponsors %}
                         <li style="margin-bottom:4px;">
-                            <a href="{% url 'manage_sponsor_edit' dup.pk %}" target="_blank" rel="noopener noreferrer">{{ dup.name }}{% if dup.city %} ({{ dup.city }}){% endif %}</a>
+                            <a href="{% url 'manage_sponsor_edit' dup.pk %}" target="_blank">{{ dup.name }}{% if dup.city %} ({{ dup.city }}){% endif %}<span class="sr-only"> (opens in a new tab)</span></a>
                             <button type="submit" form="select-dup-{{ dup.pk }}" class="btn btn-sm btn-secondary" style="margin-left:6px;">Use this sponsor</button>
                         </li>
                     {% endfor %}
@@ -1516,8 +1516,8 @@ <h3 style="font-size:16px;font-weight:700;color:#1a1a2e;margin:0 0 16px;">Edit C
     <div style="background:#fff;border:1px solid #e8e8e8;border-radius:8px;padding:24px;margin-bottom:24px;">
         <h3 style="font-size:16px;font-weight:700;color:#1a1a2e;margin:0 0 16px;">Preview &amp; Download</h3>
         <div style="display:flex;gap:12px;align-items:center;flex-wrap:wrap;">
-            <a href="{% url 'manage_composer_contract_preview' %}" target="_blank" rel="noopener noreferrer" class="btn btn-primary" style="padding:8px 20px;text-decoration:none;">
-                Preview PDF
+            <a href="{% url 'manage_composer_contract_preview' %}" target="_blank" class="btn btn-primary" style="padding:8px 20px;text-decoration:none;">
+                Preview PDF<span class="sr-only"> (opens in a new tab)</span>
             </a>
             <form method="post" style="display:inline;">
                 {% csrf_token %}

apps/sponsors/templates/sponsors/manage/contract_send.html

@@ -28,9 +28,9 @@ <h2 style="font-size:18px;font-weight:700;color:#1a1a2e;margin:0 0 4px;">Contrac
             {% if contract.document and not contract.is_draft %}
             <div class="manage-alert manage-alert-success">
                 Contract has been generated.
-                <a href="{{ contract.document.url }}" target="_blank" rel="noopener noreferrer" style="margin-left:8px;font-weight:600;">Download PDF</a>
+                <a href="{{ contract.document.url }}" style="margin-left:8px;font-weight:600;">Download PDF</a>
                 {% if contract.document_docx %}
-                <a href="{{ contract.document_docx.url }}" target="_blank" rel="noopener noreferrer" style="margin-left:8px;font-weight:600;">Download DOCX</a>
+                <a href="{{ contract.document_docx.url }}" style="margin-left:8px;font-weight:600;">Download DOCX</a>
                 {% endif %}
             </div>
             {% elif contract.is_draft %}

apps/sponsors/templates/sponsors/manage/sponsor_list.html

@@ -72,7 +72,7 @@
                 </td>
                 <td style="font-size:12px;">
                     {% if sponsor.landing_page_url %}
-                    <a href="{{ sponsor.landing_page_url }}" target="_blank" rel="noopener noreferrer" style="color:#3776ab;text-decoration:none;">{{ sponsor.landing_page_url|truncatechars:30 }}</a>
+                    <a href="{{ sponsor.landing_page_url }}" style="color:#3776ab;text-decoration:none;">{{ sponsor.landing_page_url|truncatechars:30 }}</a>
                     {% else %}
                     <span style="color:#ccc;">&mdash;</span>
                     {% endif %}

apps/sponsors/templates/sponsors/manage/sponsorship_detail.html

@@ -86,7 +86,7 @@ <h2>{{ sponsorship.sponsor.name }}</h2>
         <a href="{% url 'manage_sponsorship_notify' sponsorship.pk %}" class="btn btn-secondary">Notify</a>
         <a href="{% url 'manage_sponsorship_export' %}?selected_ids={{ sponsorship.pk }}" class="btn btn-secondary" style="font-size:11px;" title="Export this sponsorship as CSV">CSV</a>
         <a href="{% url 'manage_sponsorship_export_assets' sponsorship.pk %}" class="btn btn-secondary" style="font-size:11px;">Assets</a>
-        {% if sponsorship.sponsor %}<a href="{{ sponsorship.detail_url }}" target="_blank" rel="noopener noreferrer" class="btn btn-secondary" style="font-size:11px;" title="View what the sponsor sees">Sponsor View</a>{% endif %}
+        {% if sponsorship.sponsor %}<a href="{{ sponsorship.detail_url }}" class="btn btn-secondary" style="font-size:11px;" title="View what the sponsor sees">Sponsor View</a>{% endif %}
         {% if can_lock %}
         <form method="post" action="{% url 'manage_sponsorship_lock' sponsorship.pk %}" style="display:inline;">
             {% csrf_token %}<input type="hidden" name="action" value="lock">
@@ -381,26 +381,26 @@ <h2>Contract</h2>
         <!-- Document downloads -->
         <div style="border-top:1px solid #f0f0f0;padding-top:12px;display:flex;gap:12px;flex-wrap:wrap;">
             <!-- Preview (renders live from contract template data) -->
-            <a href="{% url 'manage_contract_preview' sponsorship.pk %}?format=pdf" target="_blank" rel="noopener noreferrer" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#f7f8fa;border:1px solid #e0e0e0;border-radius:4px;font-size:12px;color:#333;text-decoration:none;">
+            <a href="{% url 'manage_contract_preview' sponsorship.pk %}?format=pdf" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#f7f8fa;border:1px solid #e0e0e0;border-radius:4px;font-size:12px;color:#333;text-decoration:none;">
                 <span style="color:#e74c3c;font-weight:700;">PDF</span> Preview
             </a>
-            <a href="{% url 'manage_contract_preview' sponsorship.pk %}?format=docx" target="_blank" rel="noopener noreferrer" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#f7f8fa;border:1px solid #e0e0e0;border-radius:4px;font-size:12px;color:#333;text-decoration:none;">
+            <a href="{% url 'manage_contract_preview' sponsorship.pk %}?format=docx" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#f7f8fa;border:1px solid #e0e0e0;border-radius:4px;font-size:12px;color:#333;text-decoration:none;">
                 <span style="color:#3776ab;font-weight:700;">DOCX</span> Preview
             </a>
             <!-- Stored final documents: "Sent" only once they were emailed to the sponsor -->
             {% if contract.document %}
-            <a href="{{ contract.document.url }}" target="_blank" rel="noopener noreferrer" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#fff8dc;border:1px solid #ffd43b;border-radius:4px;font-size:12px;color:#333;text-decoration:none;">
+            <a href="{{ contract.document.url }}" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#fff8dc;border:1px solid #ffd43b;border-radius:4px;font-size:12px;color:#333;text-decoration:none;">
                 <span style="color:#e74c3c;font-weight:700;">PDF</span> {% if contract.sent_on %}Sent{% else %}Generated{% endif %}
             </a>
             {% endif %}
             {% if contract.document_docx %}
-            <a href="{{ contract.document_docx.url }}" target="_blank" rel="noopener noreferrer" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#fff8dc;border:1px solid #ffd43b;border-radius:4px;font-size:12px;color:#333;text-decoration:none;">
+            <a href="{{ contract.document_docx.url }}" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#fff8dc;border:1px solid #ffd43b;border-radius:4px;font-size:12px;color:#333;text-decoration:none;">
                 <span style="color:#3776ab;font-weight:700;">DOCX</span> {% if contract.sent_on %}Sent{% else %}Generated{% endif %}
             </a>
             {% endif %}
             <!-- Signed document -->
             {% if contract.signed_document %}
-            <a href="{{ contract.signed_document.url }}" target="_blank" rel="noopener noreferrer" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#e8f5e9;border:1px solid #a5d6a7;border-radius:4px;font-size:12px;color:#2e7d32;text-decoration:none;font-weight:600;">
+            <a href="{{ contract.signed_document.url }}" style="display:inline-flex;align-items:center;gap:6px;padding:6px 12px;background:#e8f5e9;border:1px solid #a5d6a7;border-radius:4px;font-size:12px;color:#2e7d32;text-decoration:none;font-weight:600;">
                 <span style="font-weight:700;">{{ signed_document_kind }}</span> Signed Contract
             </a>
             {% endif %}
@@ -435,13 +435,13 @@ <h2>Contract</h2>
                 </div>
                 <div style="display:flex;gap:8px;">
                     {% if hc.document %}
-                    <a href="{{ hc.document.url }}" target="_blank" rel="noopener noreferrer" style="font-size:11px;color:#e74c3c;text-decoration:none;">PDF</a>
+                    <a href="{{ hc.document.url }}" style="font-size:11px;color:#e74c3c;text-decoration:none;">PDF</a>
                     {% endif %}
                     {% if hc.document_docx %}
-                    <a href="{{ hc.document_docx.url }}" target="_blank" rel="noopener noreferrer" style="font-size:11px;color:#3776ab;text-decoration:none;">DOCX</a>
+                    <a href="{{ hc.document_docx.url }}" style="font-size:11px;color:#3776ab;text-decoration:none;">DOCX</a>
                     {% endif %}
                     {% if hc.signed_document %}
-                    <a href="{{ hc.signed_document.url }}" target="_blank" rel="noopener noreferrer" style="font-size:11px;color:#2e7d32;text-decoration:none;">Signed</a>
+                    <a href="{{ hc.signed_document.url }}" style="font-size:11px;color:#2e7d32;text-decoration:none;">Signed</a>
                     {% endif %}
                 </div>
             </div>