Skip to content

Commit f692d17

Browse files
gselzerclaude
andcommitted
Test completion with scijava-code-lsp-jython's jedi
scijava-code-lsp-jython now analyzes Jython with jedi-language-server, whose completions are labeled by name alone (e.g. "upper", not "name.upper"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 7371b04 commit f692d17

2 files changed

Lines changed: 6 additions & 24 deletions

File tree

‎pom.xml‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -133,22 +133,4 @@
133133
</dependency>
134134
</dependencies>
135135

136-
<build>
137-
<plugins>
138-
<plugin>
139-
<artifactId>maven-surefire-plugin</artifactId>
140-
<configuration>
141-
<!--
142-
NB: Without jedi-language-server (which scijava-code-lsp-jython
143-
brings), whose environment would be built (needing network access,
144-
and minutes) as tests first complete code: they test Jython's own
145-
analysis.
146-
-->
147-
<classpathDependencyExcludes>
148-
<classpathDependencyExclude>org.scijava:scijava-code-lsp-jedi</classpathDependencyExclude>
149-
</classpathDependencyExcludes>
150-
</configuration>
151-
</plugin>
152-
</plugins>
153-
</build>
154136
</project>

‎src/test/java/org/scijava/plugins/scripting/jython/completion/JythonDialectTest.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,15 @@ public void testScriptParameters() {
128128
// As the Python values Jython converts them to: e.g. strings are str,
129129
// whose members are Python's, not java.lang.String's.
130130
final List<String> nameMembers = complete(header + "name.upp");
131-
assertTrue("expected name.upper among " + nameMembers, nameMembers
132-
.contains("name.upper"));
131+
assertTrue("expected upper among " + nameMembers, nameMembers.contains(
132+
"upper"));
133133
assertTrue(complete(header + "name.toUpp").isEmpty());
134134
// Outputs are known too, even before the script assigns them.
135-
assertTrue(complete(header + "greeting.st").contains("greeting.strip"));
135+
assertTrue(complete(header + "greeting.st").contains("strip"));
136136
// Numbers are int, not java.lang.Integer.
137-
assertFalse(complete(header + "count.intV").contains("count.intValue"));
137+
assertFalse(complete(header + "count.intV").contains("intValue"));
138138
// Packages imported only to declare those are not completed.
139-
assertFalse(complete(header + "j").contains("java.lang"));
139+
assertFalse(complete(header + "j").contains("java"));
140140
}
141141

142142

@@ -145,7 +145,7 @@ public void testAssignmentShadowsScriptParameter() {
145145
final List<String> texts = complete(
146146
"#@ String name\nfrom java.util import ArrayList\nname = ArrayList()\nname.ensureCap");
147147
assertTrue("expected ArrayList member among " + texts, texts.contains(
148-
"name.ensureCapacity"));
148+
"ensureCapacity"));
149149
}
150150

151151

0 commit comments

Comments
 (0)