Repository navigation
llama-server: reset roofline profiler after warmup - #159
Draft
amd-callumm wants to merge 1 commit into
Draft
amd-callumm wants to merge 1 commit into
amd-callumm wants to merge 1 commit into
Conversation
Add ggml_cuda_roofline_reset() call at the end of load_model(), after all initialization completes (model load, MTP/speculative setup, mmproj load) but before any user requests. This excludes warmup/initialization overhead from TTFT measurements. Following the pattern from PR AMD-Ecosystem#42 (llama-mtmd-cli) and llama-bench: - Add roofline header include with #ifdef GGML_HIP_ROOFLINE guard - Call ggml_cuda_roofline_reset() after params propagation - Update CMakeLists.txt with compile definitions and include dirs Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
(Work in progress)
Adds ggml_cuda_roofline_reset() call at the end of load_model(), after all initialization completes (e.g. model load, speculative decode setup, mmproj load) but before any user requests. This excludes warmup/initialization overhead from TTFT measurements to give a more representative run-to-run value, useful for benchmarking purposes.
Additional information
Following the pattern from llama-mtmd-cli (ref: PR #42) and llama-bench:
Testing
Tested on a machine equipped with a gfx1151 AMDGPU:
Results of change:
NOT YET VERIFIED: TTFT or
timings.prompt_msimpact.Requirements