Repository navigation
fix: preserve URL extensions for generic downloads - #543
Open
rahulshahDEV wants to merge 2 commits into
Open
rahulshahDEV wants to merge 2 commits into
rahulshahDEV wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix.
When a download response uses
application/octet-stream, the cache manager gives the cached file a.binextension even when its URL ends in a meaningful extension such as.mp4.🆕 What is the new behavior (if this is a feature change)?
Responses with a missing or generic
Content-Typeuse the final extension in the URL path. A specific response MIME type remains authoritative, and query parameters do not affect the extension. The legacy file-service adapter follows the same rule.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
dart format --set-exit-if-changed .,flutter analyze --no-pub, andflutter test --no-pub --coveragepassed with Flutter 3.47.4. Regression tests cover the stored download path, missing and generic content types, MIME precedence, and the legacy adapter. CI should validate the example builds on supported platforms.📝 Links to relevant issues/docs
Closes #489.
🤔 Checklist before submitting