Repository navigation
[FIX] Accept --stream with one input file and without a timeout value - #2415
Open
Deepak-negi11 wants to merge 1 commit into
Open
Deepak-negi11 wants to merge 1 commit into
Deepak-negi11 wants to merge 1 commit into
Conversation
Contributor
Author
|
Note: #2410 adds a test that checks every option has a test, and |
Collaborator
CCExtractor CI platform finished running the test files on linux. 11/237 tests matched the approved output:
226 tests do not match the approved output. That is the pass/fail verdict. Whether this branch caused it is a separate question, answered below.
Compared with the tip of master — test 9744, commit 0bf2a94:
Pass there, fail here:
Fail on both but produce different output — behaviour moved even though the verdict did not:
Compared with the commit this branch was cut from — test 9750, commit d7eb132:
Pass there, fail here:
Fail on both but produce different output — behaviour moved even though the verdict did not:
This branch changes the behaviour of 110 test(s) relative to the tip of master. Those are the ones worth looking at; anything else in the list fails the same way on both sides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
Sample: Closed Caption EIA.ts
I found this while writing tests for #2408.
--streamcan't be used at all in the Rust parser:--stream 5 file.tsexits with "Live stream mode only supports one input file" (exit 3). The C parser only refuses more than one file.--stream file.tsreads the file name as the timeout and exits with "Malformed parameter" (exit 7).--stream 2 file.ts-s 2 file.ts--stream file.ts--stream 5 file.ts file.tsChanges:
normalize_legacy_args(lib.rs): if the argument after-s/--streamis not a number, use--stream=-1, which is the same rule as the C parser.parse_parameters(parser.rs): a negative value means no timeout (live_stream = None, copied to C as -1), and the check now refuses only more than one input file.Tests: 3 new tests. Each one fails if its half of the fix is removed.