Repository navigation
Conversation
pulk17
requested review from
canihavesomecoffee and
thealphadollar
as code owners
October 24, 2026 18:57
|
Took a look through \web/src/lib/api.ts. Querying \MASTER_RUNS\ directly makes a lot of sense so PR runs don't clutter the test history. Also nice catch with \oldCommitRows\ checking both platforms per commit so failures don't get hidden. Checks look all green on my end too. |
the list picked master runs out of the newest 40, so it went blank whenever pr runs filled them, and it read whichever platform ran last, so a linux-only failure could show as passing. pr runs are now labelled in the detail panel.
pulk17
force-pushed
the
web-test-history
branch
from
October 25, 2026 05:06
4a4ac13 to
c2e1939
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Problem
On
/app/testsevery test says "no runs yet", although they do have runs, and the "failing" toggle shows nothing.Two bugs in how each test's history was built, both from the original Web-Api code:
Fix
/runs?branch=master&repository=CCExtractor/ccextractor. PR runs are stored on branchpull_request, and fork pushes under their own repository, so neither can crowd it out. Only finished runs (pass/fail) are used.PRtag, and the caption says so.Testing
Against a copy of the production database (data up to June):
tsc -b,oxlint --deny-warnings(pinned and latest) andbuild:appall pass.That data predates the stuck queue, so the empty list itself isn't reproducible locally. The fix removes the dependency on the shared list, so it no longer matters what's in it.