[youknowme19]

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

• I have never used the project.
• I have used the project briefly.
• I have used the project extensively, but have not contributed previously.
• I am an active contributor to the project.

---

Description

This pull request resolves an issue where requesting /test/restart_test/<test_id> or /test/stop_test/<test_id> with a non-existent test_id results in an unhandled AttributeError (HTTP 500) for administrators or an improper HTTP 403 Forbidden for non-administrators, rather than the expected HTTP 404 Not Found error page.

Fixes #1248

Root Cause

In mod_test/controllers.py:

• Both restart_test(test_id) and stop_test(test_id) queried test = Test.query.filter(Test.id == test_id).first() but omitted a test is None check.
• For administrator accounts (g.user.is_admin == True), code execution proceeded directly to inspect test.id (for Celery task revocation / logging), which crashed with AttributeError: 'NoneType' object has no attribute 'id' and caused Flask to return an unhandled HTTP 500 Internal Server Error.
• For non-admin accounts (Role.tester), the test_fork query returned None, which triggered the restricted endpoint check not g.user.is_admin and test_fork is None and aborted with HTTP 403 Forbidden instead of notifying the user that the test does not exist.

Solution

• Added explicit if test is None: checks in both restart_test and stop_test.
• Logged an error (g.log.error(f"test with id: {test_id} not found!")) and raised TestNotFoundException(f"Test with id {test_id} does not exist").
• This integrates cleanly with the existing @mod_test.errorhandler(TestNotFoundException) which renders test/test_not_found.html with status code 404, matching standard behavior in by_id, download_build_log_file, ccextractor_version, and by_commit.

Verification & Testing

• Added 4 unit regression tests in tests/test_test/test_controllers.py:
  • test_restart_nonexistent_test_as_admin
  • test_restart_nonexistent_test_as_tester
  • test_stop_nonexistent_test_as_admin
  • test_stop_nonexistent_test_as_tester
• Executed full test suite with TESTING=true ./venv/bin/nose2: All 811 tests passed in 65.3s.
• Executed all linting and type-checking suites:
  • dodgy -i venv: Passed (0 warnings)
  • isort . --check-only: Passed
  • pydocstyle --config=./.pydocstylerc: Passed
  • mypy .: Passed (157 source files, no issues)
  • pycodestyle ./ --config=./.pycodestylerc: Passed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud