Repository navigation
[FIX] Pass the select statement to in_() instead of calling .select() on it - #1254
Open
ARYAMANN7279 wants to merge 1 commit into
Open
ARYAMANN7279 wants to merge 1 commit into
ARYAMANN7279 wants to merge 1 commit into
Conversation
Select.select() was deprecated in SQLAlchemy 1.4 and is gone in 2.1, so the sample page and the test average time code fail with the version in the dependency update PR. in_() accepts the select statement directly, which also works with the pinned 2.0.
ARYAMANN7279
requested review from
canihavesomecoffee and
thealphadollar
as code owners
October 26, 2026 17:47
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



In raising this pull request, I confirm the following:
My familiarity with the project is as follows:
The dependency update to SQLAlchemy 2.1 (#1251) fails on every Python version.
Select.select()was deprecated in 1.4 and is removed in 2.1, so these calls raiseAttributeError: 'Select' object has no attribute 'select':mod_sample/controllers.py,display_sample_info:regression_test_id.in_(sq.select()), 4 timesmod_ci/controllers.py, the average time code:test_id.in_(platform_tests.select())in_()accepts the select statement directly, so this passes it as it is. The query means the same thing, and it works on the pinned 2.0 and on 2.1.I ran the whole test suite on Linux with Python 3.14. With SQLAlchemy 2.1.6 before this change: 5 failed (
test_sample_pass,test_sample_fail,test_sample_id,test_sample_create_xml,test_progress_type_request). After: 807 passed. With the pinned 2.0.53: 807 passed before and after, and the SQLAlchemy deprecation warnings for these lines are gone.