Repository navigation
fix(web): clear stale converter selection on invalid input - #3054
Open
yashranaway wants to merge 3 commits into
Open
yashranaway wants to merge 3 commits into
yashranaway wants to merge 3 commits into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Thanks for this. One problem it introduces:
Once that's in, we'll re-run the Greptile review. It needs a 5/5 plus green CI to merge. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@richiemcilroy done in ebc9cde. new selections are ignored while a conversion runs and the file input is disabled during it. the new test drops an invalid file mid-conversion and checks the original file and a working download are still there when it finishes. greptile is 5/5. |
…onverters # Conflicts: # .github/workflows/ci.yml
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the format converter tools, if you picked a valid video and then picked a wrong type or a file over 500mb, it showed the error but kept the first video selected with convert still enabled. so you could end up converting a file you thought you'd replaced.
picking a new file now clears the old selection first, along with the previous output and its blob url, and only sets the new one if it passes the checks. test picks a valid file then an invalid and an oversized one and checks nothing stays selected. also added it to the web test list in ci.


Confidence Score: 5/5
The PR appears safe to merge; no blocking issues remain.Summary
Clears the old file and converted output before checking a replacement.
No new actionable issues found. Tests were inspected but not run.
Reviews (2) · Last reviewed commit: "fix(web): keep converter selection durin..." · Reviewed by Greptile