Repository navigation
fix: keep pending Loom conversions pointed at the owner's original after a move - #3099
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
… stale owner path
Member
Author
|
@greptileai review |
Member
Author
|
@greptileai review |
richiemcilroy
marked this pull request as ready for review
October 24, 2026 13:05
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VP9 Loom imports keep their original WebM and record its storage key in
metadata.loomDeferredProcessing.rawFileKeyuntil the first view converts it. That key includes the owner's id. Moving such a video to another owner (the operator reassign/backfill tools) copied the file to the new owner's prefix but left the key pointing at the old one, so first-view conversion silently stopped matching.lib/loom-import-reassign.ts: the owner switch rewritesrawFileKeyfrom the old owner's prefix to the new one in the same conditional update. Videos whose conversion is already running (status: "started") are skipped instead of moved.lib/loom-import-backfill.ts: a backfill item repairs a pendingrawFileKeythat still points at another owner's prefix for the same video, so videos moved before this fix can be corrected by running them again.
The PR appears safe to merge.Summary
Keeps deferred Loom conversions pointed at the copied original when a video changes owners.
All four previous threads were checked against the current code. Their fixes are present; none supplied a comment number.
Reviews (4) · Last reviewed commit: "fix: roll back a Loom move when its orig..." · Reviewed by Greptile