Repository navigation
feat(desktop-gpui): add a copy file action to finished exports - #3100
Open
yashranaway wants to merge 3 commits into
Open
yashranaway wants to merge 3 commits into
yashranaway wants to merge 3 commits into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a copy file button next to open file once an export finishes. it copies the exported file into the same folder as "name copy.ext", then "name copy 2.ext" and so on, and never overwrites anything since it only creates a file that doesn't exist yet. the copy runs off the ui thread, shows the new name when it's done and the error if it fails.
left screenshots out for now, the native screenshot is a bundle folder and copying the image inside it isn't useful.
Fixes #3074


Confidence Score: 5/5
The PR appears safe to merge; no new actionable issues were found.Summary
Adds Copy File beside Open File after a successful file export.
Reviews (3) · Last reviewed commit: "fix(desktop-gpui): only offer actions th..." · Reviewed by Greptile