Repository navigation
feat(desktop-gpui): let Open File show the export in its folder - #3101
Open
yashranaway wants to merge 3 commits into
Open
yashranaway wants to merge 3 commits into
yashranaway wants to merge 3 commits into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
…vior # Conflicts: # apps/desktop-gpui/src/settings_window.rs # apps/desktop-gpui/src/store.rs
Contributor
Author
|
@greptileai review |
Comment on lines
+768
to
+769
| OpenFile = "openFile", "Open the file"; | ||
| ShowInFolder = "showInFolder", "Show in folder"; |
Contributor
There was a problem hiding this comment.
OpenFileBehaviour supplies English labels, and segmented displays them directly. When users select another language, the row title and description translate, but “Open the file” and “Show in folder” do not. Users still need to read English to distinguish the choices. Add translated labels for both.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop-gpui/src/store.rs
Line: 768-769
Comment:
**Choices stay in English**
`OpenFileBehaviour` supplies English labels, and `segmented` displays them directly. When users select another language, the row title and description translate, but “Open the file” and “Show in folder” do not. Users still need to read English to distinguish the choices. Add translated labels for both.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a general setting for what open file does after an export: open the file like today, or show it in its folder. the export button just asks the existing open and reveal helpers based on that setting, so it picks up the windows terminal fix from #2965 or #2316 whichever lands.
the default stays open the file, and old settings files without the key load with that default.
Fixes #3073
The PR appears safe to merge, with a non-blocking translation gap.Findings
Fix with agent prompt
Summary
Adds a setting that makes the export’s Open File button either open the file or show its folder.
Reviews (3) · Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." · Reviewed by Greptile