Repository navigation
perf(desktop-gpui): borrow presets when rendering the menu - #3103
Merged
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the editor's presets dropdown cloned the whole presets store on every repaint while it was open, which deep copies each preset's full project config json. hovering rows repaints it constantly. it only needs to read the store, so it borrows it now.
ignored bench building the menu 10 times per sample, 31 samples, real default preset configs, dev profile on linux: 5 presets 364 to 99µs per repaint, 50 presets 2.63 to 0.53ms. the store is unchanged after rendering.
The PR appears safe to merge; no actionable issues were found.Summary
render_presets_menunow borrows the presets store instead of copying every preset’s configuration on each render.No actionable issues found. Build and runtime checks were not run.
Reviews (1) · Last reviewed commit: "perf(desktop-gpui): borrow presets when ..." · Reviewed by Greptile