Repository navigation
fix: reject JSON arrays as 3p and WebMCP tool params - #2785
Merged
wolfib merged 3 commits intoSep 28, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rooKywooKy
approved these changes
Sep 20, 2026
wolfib
reviewed
Sep 23, 2026
wolfib
left a comment
Contributor
There was a problem hiding this comment.
The change looks good to me, thanks!
Please sign the CLA and we can get this merged.
Contributor
Author
Merged
via the queue into
ChromeDevTools:main
with commit Sep 28, 2026
c14e616
28 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execute_3p_developer_toolandexecute_webmcp_toolparse a JSON string as params. Arrays passtypeof parsed === 'object' && parsed !== null, so[]skipped the object check and failed later with a misleading error (Tool not foundor a Puppeteer private-field TypeError).Reject arrays the same way
wsHeadersalready does.Testing
npm run test tests/tools/thirdPartyDeveloper.test.ts tests/tools/webmcp.test.tsnpm run typechecknpm run check-formatAI-assisted (Grok)