Skip to content

feat: resolve config defaults after merging CLI and config file #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lightning00Blade merged 3 commits into from
Sep 29, 2026
Merged

feat: resolve config defaults after merging CLI and config file #2849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f9d7b9
feat: resolve config defaults after merging CLI and config file
Lightning00Blade Sep 25, 2026
cac095d
fixes
Lightning00Blade Sep 29, 2026
9427090
fix
Lightning00Blade Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/config/browser-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export const browserOptions = {
type: 'string',
description:
'Custom headers for WebSocket connection in JSON format (e.g., \'{"Authorization":"Bearer token"}\'). Only works with --wsEndpoint.',
implies: 'wsEndpoint',
coerce: (val: string | undefined) => {
if (!val) {
return;
Expand Down Expand Up @@ -91,7 +90,7 @@ export const browserOptions = {
type: 'boolean',
description:
'If specified, creates a temporary user-data-dir that is automatically cleaned up after the browser is closed. Defaults to false.',
defaultDescription: 'false',
default: false,
},
userDataDir: {
type: 'string',
Expand All @@ -103,7 +102,7 @@ export const browserOptions = {
description:
'Specify a different Chrome channel that should be used. The default is the stable channel version.',
choices: ['canary', 'dev', 'beta', 'stable'] as const,
defaultDescription: 'stable',
default: 'stable' as const,
},
proxyServer: {
type: 'string',
Expand Down
Loading
Loading