Repository navigation
refactor: validate resolved config with a zod schema - #2850
Closed
Lightning00Blade wants to merge 2 commits into
Closed
Lightning00Blade wants to merge 2 commits into
Lightning00Blade wants to merge 2 commits into
Conversation
Lightning00Blade
added this pull request to stack #2851
September 28, 2026 08:33
Lightning00Blade
force-pushed
the
cd4a-3-zod-validation
branch
from
September 28, 2026 09:08
b5d60a7 to
00bb7a2
Compare
Lightning00Blade
force-pushed
the
cd4a-3-zod-validation
branch
from
September 28, 2026 11:45
00bb7a2 to
1f1c5a7
Compare
Lightning00Blade
force-pushed
the
cd4a-3-zod-validation
branch
2 times, most recently
from
September 28, 2026 13:09
b60f8d5 to
d82340e
Compare
Lightning00Blade
force-pushed
the
cd4a-3-zod-validation
branch
from
September 28, 2026 13:29
d82340e to
e634ffc
Compare
Lightning00Blade
force-pushed
the
cd4a-3-zod-validation
branch
from
September 28, 2026 14:13
e634ffc to
1e520f7
Compare
Lightning00Blade
force-pushed
the
cd4a-3-zod-validation
branch
from
September 28, 2026 14:53
1e520f7 to
ecbbb38
Compare
Lightning00Blade
force-pushed
the
cd4a-3-zod-validation
branch
from
September 28, 2026 15:09
ecbbb38 to
31da4d6
Compare
Parse CLI arguments and the JSON config file without yargs defaults so only explicit user intent is captured, merge them with CLI taking precedence, then apply defaults (including the --viaCli ones). Conflict checks now only consider explicitly provided arguments, so implicit defaults such as channel=stable can no longer conflict with explicit flags. Also restores --help/--version exiting via a shared buildCliParser and adds edge-case tests for config parsing, precedence and conflicts.
Move the mutually exclusive argument check into a zod superRefine so schema validation is the single final gatekeeper for the resolved configuration. No behavior change.
Lightning00Blade
force-pushed
the
cd4a-3-zod-validation
branch
from
September 28, 2026 15:57
31da4d6 to
915b23b
Compare
Collaborator
Author
|
Dropping this PR: the default resolution and validation it added are now covered in #2849, which also splits parsing into separately testable steps. |
An error occurred while trying to automatically change base from
cd4a-2-late-defaults
to
main
September 29, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the mutually exclusive argument check into a zod superRefine so schema
validation is the single final gatekeeper for the resolved configuration.
No behavior change.
Stack created with GitHub Stacks CLI • Give Feedback 💬