Repository navigation
Conversation
Collaborator
|
@paviad Can I ask you to split the changes in two it would be much easier to review and merged the changes. |
Author
What should be contained in each part? |
Collaborator
|
Its the two things you listed. One related to argument and the other related to the internal handling of things. |
Author
|
Ok will split - I will find the issue relating to the rejected startup (part 1) - I should create one if one doesn't exist, correct? |
Remove the categoryExtensions conflicts with autoConnect, browserUrl and wsEndpoint added in ChromeDevTools#2753. Chrome 149+ supports extension debugging over these connections, and 1.10.1 accepts the combination. Update the --categoryExtensions help text, generated docs and the troubleshooting skill to state the Chrome 149+ requirement for attach modes. Fixes ChromeDevTools#2989
paviad
force-pushed
the
fix/category-extensions-attach
branch
from
October 9, 2026 13:29
1d56a87 to
ed595e1
Compare
Author
|
@Lightning00Blade Done, split in two:
Both are rebased on current |
Lightning00Blade
self-requested a review
October 9, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2989.
Split at the reviewer's request: the target-filter fix that makes extension pages visible when attached is now #3047. This PR only lifts the startup rejection and updates the related text.
#2753 added
['categoryExtensions', 'autoConnect']and['categoryExtensions', 'browserUrl', 'wsEndpoint']toCONFLICTING_ARGS, somainexits at startup with "mutually exclusive" for these combinations. 1.10.1 accepts them. The help text still said attach modes were unsupported only "until 149", and Chrome 149 has shipped. In #2852, @OrKoN noted that recent Chrome doesn't need a pipe connection, and said the rejection should be fixed.Changes
src/config/mcp-options.ts: remove the twocategoryExtensionsconflict groups.--viaClikeeps its existing default (extensions off when attaching unless requested explicitly).--categoryExtensionshelp text (category-options.ts, regenerateddocs/configuration.md) andskills/troubleshooting/SKILL.md: replace the "pipe only / until 149" note with "requires Chrome 149 or later" for attach modes.tests/cli.test.ts: the conflict tests now assert the combinations are accepted.#3047 should land first or together with this one. Otherwise attaching with
--categoryExtensionsis accepted but extension pages stay hidden fromlist_pages.Testing
npm run gen(onlydocs/configuration.mdchanged) andnpm run check-format: clean.node scripts/test.js tests/cli.test.ts tests/browser.test.ts: all pass.--browserUrl http://127.0.0.1:<port> --categoryExtensions=true, andlist_pageslists the extension tab under## Extension Pages.--autoConnectand--wsEndpointwere covered only by the unit tests.Not tested: Chrome 149 through 153, and anything before 149. The "Chrome 149 or later" requirement in the help text keeps the boundary from the original note in #1922 rather than one I measured. Following the existing convention (
--autoConnect"Chrome 144+",--allowedUrlPattern"Chrome 149+"), it's documented, not checked at runtime. I'm happy to add a runtime check in a follow-up if you'd prefer one.🤖 Generated with Claude Code