Skip to content

Flush the handshake addendum so idle connections survive the server's handshake timeout #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slabko merged 1 commit into from
Oct 7, 2026
Merged

Flush the handshake addendum so idle connections survive the server's handshake timeout #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions clickhouse/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,13 @@ bool Client::Impl::Handshake() {
}

if (server_info_.revision >= DBMS_MIN_PROTOCOL_VERSION_WITH_ADDENDUM) {
// The server reads the addendum as part of the handshake and, since
// handshake_timeout_milliseconds (default 30s), drops the connection
// if it does not arrive in time. Without this flush the addendum only
// left the buffer with the first query, so a connection that was idle
// for 30s after connecting was closed with SOCKET_TIMEOUT.
WireFormat::WriteString(*output_, std::string());
output_->Flush();
}

return true;
Expand Down
Loading