Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334.
Shift-line terrain painting currently ignores the selected brush size. This applies the brush at each line anchor using whole-tile offsets, and keeps the original brush settings for redo. Short and zero-length previews use the placement mutation so their footprint matches the brush. Adjusted endpoint handling also allows short multi-cell strokes to commit correctly.
Height-changing placement and previews now refresh cell lighting. Final review caught stale brightness in the short-preview path; nine regression cases reproduced it before the correction.
Validation
Native Windows verification is still outstanding. Local editor/test builds passed with content compilation disabled. The full solution has an inherited missing external
Rampastring.Updaterdependency that also fails on pristine source. Keeping this as a draft for review and Windows validation.Screenshots
With a 3x3 brush selected, the original Shift stroke remains one tile wide:
The fixed 3x3 stroke uses the brush width:
A 5x5 brush produces a wider stroke:
Implementation, automated tests and this PR description were prepared with Codex assistance. Manual observations and screenshots are from @keysmon.