Skip to content

Fix: fully-qualify \Closure in docblock type hints for correct reflection-copy resolution #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bolivir wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: fully-qualify \Closure in docblock type hints for correct reflection-copy resolution #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13406b9
Fix: fully-qualify \Closure in docblock type hints for correct reflec…
bolivir Aug 26, 2026
14bebbf
Fix: fully-qualify Eloquent, RuntimeException and Authenticatable typ…
bolivir Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Codeception/Module/Laravel/InteractsWithAuthentication.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function amActingAs(Authenticatable $user, ?string $guardName = null): vo
*
* // can be verified with $I->seeAuthentication();
* ```
* @param Authenticatable|array $user
* @param \Illuminate\Contracts\Auth\Authenticatable|array $user
* @param string|null $guardName
*/
public function amLoggedAs($user, ?string $guardName = null): void
Expand Down
6 changes: 3 additions & 3 deletions src/Codeception/Module/Laravel/InteractsWithContainer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public function haveApplicationHandler(callable $handler): void
* ```
*
* @param string $abstract
* @param Closure|string|null $concrete
* @param \Closure|string|null $concrete
* @param bool $shared
*/
public function haveBinding(string $abstract, $concrete = null, bool $shared = false): void
Expand All @@ -108,7 +108,7 @@ public function haveBinding(string $abstract, $concrete = null, bool $shared = f
*
* @param string $concrete
* @param string $abstract
* @param Closure|string $implementation
* @param \Closure|string $implementation
*/
public function haveContextualBinding(string $concrete, string $abstract, $implementation): void
{
Expand Down Expand Up @@ -139,7 +139,7 @@ public function haveInstance(string $abstract, object $instance): void
* ```
*
* @param string $abstract
* @param Closure|string|null $concrete
* @param \Closure|string|null $concrete
*/
public function haveSingleton(string $abstract, $concrete): void
{
Expand Down
13 changes: 6 additions & 7 deletions src/Codeception/Module/Laravel/InteractsWithEloquent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

use Illuminate\Database\ConnectionResolverInterface as Db;
use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
use Illuminate\Database\Eloquent\Collection as EloquentCollection;
use Illuminate\Database\Eloquent\Factories\Factory as EloquentFactory;
use Illuminate\Database\Eloquent\FactoryBuilder;
use Illuminate\Database\Eloquent\Model as EloquentModel;
Expand Down Expand Up @@ -82,7 +81,7 @@ public function grabNumRecords(string $table, array $attributes = []): int
*
* @param string $table
* @param array $attributes
* @return array|EloquentModel
* @return array|\Illuminate\Database\Eloquent\Model
* @part orm
*/
public function grabRecord($table, $attributes = [])
Expand Down Expand Up @@ -145,7 +144,7 @@ public function have(string $model, array $attributes = [], string $name = 'defa
*
* @see https://laravel.com/docs/7.x/database-testing#using-factories
*
* @return EloquentModel|EloquentCollection
* @return \Illuminate\Database\Eloquent\Model|\Illuminate\Database\Eloquent\Collection
* @part orm
*/
public function haveMultiple(string $model, int $times, array $attributes = [], string $name = 'default')
Expand All @@ -170,8 +169,8 @@ public function haveMultiple(string $model, int $times, array $attributes = [],
*
* @param string $table
* @param array $attributes
* @return EloquentModel|int
* @throws RuntimeException
* @return \Illuminate\Database\Eloquent\Model|int
* @throws \RuntimeException
* @part orm
*/
public function haveRecord($table, $attributes = [])
Expand Down Expand Up @@ -208,7 +207,7 @@ public function haveRecord($table, $attributes = [])
*
* @see https://laravel.com/docs/7.x/database-testing#using-factories
*
* @return EloquentCollection|EloquentModel
* @return \Illuminate\Database\Eloquent\Collection|\Illuminate\Database\Eloquent\Model
* @part orm
*/
public function make(string $model, array $attributes = [], string $name = 'default')
Expand All @@ -232,7 +231,7 @@ public function make(string $model, array $attributes = [], string $name = 'defa
*
* @see https://laravel.com/docs/7.x/database-testing#using-factories
*
* @return EloquentCollection|EloquentModel
* @return \Illuminate\Database\Eloquent\Collection|\Illuminate\Database\Eloquent\Model
* @part orm
*/
public function makeMultiple(string $model, int $times, array $attributes = [], string $name = 'default')
Expand Down
Loading