Repository navigation
chore: sync vendored Comfy Router spec (cloud@90a81a4b) - #222
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
2 times, most recently
from
October 21, 2026 00:20
a90c465 to
492f76b
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 21, 2026 02:32
492f76b to
9e56669
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 21, 2026 19:54
9e56669 to
99b018c
Compare
cloud-code-bot
Bot
force-pushed
the
chore/sync-router-spec
branch
from
October 22, 2026 08:49
99b018c to
8c45744
Compare
The Router sync adds an optional If-None-Match header parameter to GET /v2/models. The catalog contract test collected every parameter regardless of location, so the header broke its cursor/limit check. Match only the query parameters there, and assert that every non-query parameter is optional, since models.list() never sends one.
wei-hai
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
This updates the SDK's local copy of the Router service's published contract. The new contract adds no new kinds of error, so no error classes change. One test is adjusted so it keeps checking the right thing now that the model-list route also accepts an optional caching header.
Automated sync of the public Comfy Router spec, projected from the canonical contract (internal notes stripped). Source:
cloud@90a81a4b.It lands at
spec/router-openapi.yamland is a contract of its own — it is never merged into another vendored spec in this repo.This is the single rolling sync pull request for
spec/router-openapi.yaml. It liveson
chore/sync-router-spec, and every later change to the upstream contractforce-updates this same branch and refreshes this description with the
new source commit — so there is only ever one open sync PR for this
spec, and its diff is always the current one.
The error-type class commit described above is the one commit that
belongs here. Once a commit of yours is on this branch, the next sync
refuses to force-update it and fails, naming this pull request, so
land this pull request promptly. Push any other follow-up work to a
branch of your own.
No Router operations are currently unserved (as of
cloud@90a81a4b).This note auto-refreshes while this PR is open: a change to comfy-api's
exclude list rewrites this section in place, and a change to the
PUBLISHED Router surface opens its own sync PR carrying the set as of
ITS commit. Once this PR is merged the note is a permanent snapshot —
for the current state, check
services/comfy-api/drip/codegen.yamlinComfy-Org/cloud directly.
No code generation for this spec yet. Nothing in this repo
generates code from
spec/router-openapi.yaml, so this sync has no low layer toregenerate and the workflow that opened this pull request could not
prepare one for you.
That is not the same as nothing to do. This repo keeps a hand-written
surface coupled to this contract — its error-type class table — with
a drift check of its own, so a sync that adds an error bucket still
needs a commit here before this pull request goes green. When code
generation does land for this spec, its command is configured
upstream, in the same sync workflow that opened this PR, and this
section becomes the automatic one.
Commit that class to this branch and land this pull request once it
is green. The class cannot land separately: the drift check also
fails on a class the vendored spec does not declare yet. Your commit
is safe here — the next sync will not overwrite it; it fails instead,
naming this pull request — but every later sync for this spec stays
paused until this pull request is merged (which deletes the branch,
so the following sync starts fresh), or closed and its branch
deleted.
Commits on this branch beyond the sync
test(router): read only query parameters off the catalog route: the sync adds an optionalIf-None-Matchheader parameter toGET /v2/models. The catalog contract test collected every parameter regardless of location, so it now checks only the query parameters (cursor,limit) and also asserts that every non-query parameter stays optional, becausemodels.list()never sends one. This sync adds no new Router error type, so no error-type class commit is needed here: the drift check reports all 19 types covered.Provenance
Verified:
ruff check .,ruff format --check .,mypy src: clean at3e42c6cpytest: 1265 passed, 9 skipped (the gateway e2e test is skipped without credentials)scripts/check_drift.py: models in sync; all 19 Router error types covered and blessedscripts/check_public_repo_hygiene.py: no findings3e42c6c: every check passes, including the four-version test matrixDeviations: