Repository navigation
Conversation
tuzengji
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
October 15, 2026 11:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Addresses finding 2 of #786.
With
OPENBOT_SINGLE_USER=true,example.com:3010inOPENBOT_PUBLIC_URL,OPENBOT_APP_URLorTRUSTED_ORIGINSpreviously passed startup with a private-network warning.new URL()interprets that value as a scheme with an empty hostname, which then matched the single-label LAN-name rule.Classify an empty normalized hostname as public so startup refuses it. The existing loopback and private-network cases retain their behavior. Regression cases exercise all three configuration inputs through
loadConfig.Where it runs
Boundary and audit
Changelog
Unreleasednote describing the startup refusal.Proof
Revalidated on October 17 after merging
mainat12c3a69. The changelog conflict is resolved with both entries retained. The 147 configuration/single-user tests, formatting, lint, type checks, and workspace builds all pass on the merged branch.On macOS with Bun 1.4.3, invoked through
npm exec --package bun@1.4.3:bun test server/tests/config.test.ts server/tests/single-user.test.ts: before the production fix, 144 passed and the three new cases failed because startup did not throw; afterwards, 147 passed, 0 failed.bun run format:check,bun run lint,bun run typecheck,bun run build: passed.git diff --check: passed.The full database integration suite was not run; this change was exercised through configuration unit tests without a model, external service or database.
AI disclosure: Codex authored and tested this change, with an independent agent review of the diff and regression evidence.