Repository navigation
fix(read_console): allow excluding MCP diagnostics from project checks - #1448
MohammediYunus wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughConsole reads now support an option to include or exclude recognized MCP for Unity diagnostics. The option is available through the server tool and editor CLI. Filtering occurs before count and paging limits. ChangesConsole MCP log filtering
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant ReadConsoleTool
participant UnityHandleCommand
participant GetConsoleEntries
ReadConsoleTool->>UnityHandleCommand: includeMcpLogs option
UnityHandleCommand->>GetConsoleEntries: includeMcpLogs setting
GetConsoleEntries->>GetConsoleEntries: Skip matching entries when false
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The console filtering option reaches Unity as intended. No identified issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 30.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 7 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
MCP for Unity's own transport diagnostics can consume
read_consolelimits before project warnings and errors are returned. This addsinclude_mcp_logs=falseto exclude those entries before filtering limits and pagination, with the equivalent CLI flag--no-mcp-logs.The existing default remains unchanged: MCP diagnostics are included unless explicitly excluded. This keeps bridge troubleshooting compatible while giving project checks the filter requested in #1434. Happy to discuss changing the default separately.
Type of Change
Changes Made
Compatibility / Package Source
file:reference inTestProjects/UnityMCPTests.beta; no package/version changes included.Testing
git diff --checkpassed.Related Issues
Related to #1434.
Additional Notes
The tests above were run locally; broader platform compatibility remains for CI and maintainer review.
Summary by CodeRabbit