Repository navigation
refactor: replace findable button wrappers with mui button (#4994) - #4995
Merged
Merged
Conversation
frano-m
marked this pull request as ready for review
October 20, 2026 06:00
frano-m
marked this pull request as draft
October 20, 2026 06:00
1 task
frano-m
marked this pull request as ready for review
October 20, 2026 06:11
Contributor
Author
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The replacements are narrowly scoped, match the migration requirements, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Prepares the app for findable-ui’s button-wrapper retirement, addressing #4994 while preserving existing styling and behavior.
Changes:
- Replaces primary and text button wrappers with MUI buttons and shared presets.
- Preserves archive-preview styling and homepage link handling.
- Uses MUI
ButtonPropsfor the retained outline wrapper.
| File | Description |
|---|---|
| app/components/Detail/components/GeneratedMatricesTables/components/FileLocationArchivePreview/fileLocationArchivePreview.tsx | Applies the primary text preset. |
| app/components/Detail/components/GeneratedMatricesTables/components/FileLocationArchivePreview/fileLocationArchivePreview.styles.ts | Styles MUI Button directly. |
| app/components/Detail/components/EntityGuard/components/EntityWithdrawn/entityWithdrawn.tsx | Replaces the homepage button wrapper. |
| app/components/Detail/components/EntityGuard/components/EntityDeprecated/entityDeprecated.tsx | Replaces the homepage button wrapper. |
| app/components/common/Button/components/ButtonOutline/buttonOutline.tsx | Switches props typing to MUI. |
Review effort: Balanced
NoopDog
approved these changes
Oct 20, 2026
NoopDog
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Fran, looks good. The red Playwright checks are GitHub's ubuntu-latest rollout to 26.04, which Playwright doesn't support yet, not this change.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
frano-m
force-pushed
the
frano-m/4994-replace-findable-button-wrappers
branch
from
October 21, 2026 04:47
a542577 to
36d91f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4994. Part of DataBiosphere/findable-ui#1125 and must land before DataBiosphere/findable-ui#1126 ships.
ButtonPrimary→ MUIButtonwithBUTTON_PROPS.PRIMARY_CONTAINEDinEntityDeprecatedandEntityWithdrawn(still wrapped innext/linklegacyBehavior).ButtonTextPrimary→styled(Button)from@mui/materialinfileLocationArchivePreview.styles.ts, keepingfont-weight/justify-self;BUTTON_PROPS.PRIMARY_TEXTis spread at the call site. The wrapper's hover rule (transparent background + underline) is already covered by findable's themeprimary/textvariant.ButtonOutlinewrapper now types its props with MUIButtonPropsinstead of findable'scomponents/common/Button/button.ButtonPrimary,ButtonTextPrimaryorcomponents/common/Button/buttonremain.Verification
Computed styles of each button were snapshotted on
mainand compared after the change, in default and hover states: zero differences for all three buttons./.FileNameCellignoresarchivePreviewsince Update findable-ui to latest version 47.0.2 #4613), so it was temporarily rendered locally for comparison only.Screenshots
Checks
build-ma-dev:hca-dcp✅🤖 Generated with Claude Code