Skip to content

feat: move anvil identity tags back to columns and add a file download menu (#5000) - #5001

Draft
KasparsNaglis wants to merge 1 commit into
DataBiosphere:mainfrom
KasparsNaglis:kaspars/5000-anvil-columns-download-menu
Draft

KasparsNaglis wants to merge 1 commit into
DataBiosphere:mainfrom
KasparsNaglis:kaspars/5000-anvil-columns-download-menu

Conversation

@KasparsNaglis

@KasparsNaglis KasparsNaglis commented Oct 22, 2026 •

Copy link
Copy Markdown

Closes #5000

Important

Needs DataBiosphere/findable-ui#1145 released, then a findable-ui bump in this PR. Until then the type check and build fail in CI. Locally it builds and runs against a linked findable-ui build.

What

Columns

  • All 5 tabs: the identity cell tags are their own columns again, and the dataset is its own column. Identity cells keep only the title, clamped to 2 lines.
  • Datasets: Access, Identifier and Consent Group columns.
  • Donors, BioSamples, Activities: Dataset, plus the former tag fields (organism type, phenotypic sex, reported ethnicity, biosample type, anatomical site, activity type).
  • Files: the folder path shows under the file name and wraps between folders. File names wrap at any character. Dataset, File Format and Data Modality (hidden) are columns again.

Sizing

  • Value columns hug their values up to a max width, wrap above it, and clamp to 2 lines. The full value shows on hover or focus.
  • Each column's max width is the 90th percentile value length in anvil15, kept between 120px and 400px (site-config/anvil-cmg/dev/index/common/columns.ts).

Download menu

  • The DRS URI column is gone. The download button opens a menu: "Download file" (open-access files only, with the reason otherwise) and "Copy DRS URI".
  • The menu shares its styles with Request Access (app/components/common/DropdownMenu).
  • Removed the unused CopyCell and the DRS_URI category key.

Why

The tags under each title took over the first column, and the links got harder to read. The DRS URI column was cut off, so only its copy button was useful.

Notes

Testing

  • Unit tests updated for the identity, column and download menu builders. All 200 pass; lint, tsc and prettier pass.
  • AnVIL Playwright suite passes in Chromium (44 tests).
  • Checked in the browser with prod data, at 1458px and 1920px.

🤖 Generated with Claude Code

…d menu (DataBiosphere#5000)

- show the identity cell tags as their own columns on all 5 anvil tabs,
  with the dataset as its own column; identity cells keep only the
  title, clamped to two lines
- datasets: access, identifier and consent group columns
- donors, biosamples, activities: dataset, organism type, phenotypic
  sex, reported ethnicity, biosample type, anatomical site and activity
  type columns
- files: show the folder path under the file name, wrapping between
  folders; file names wrap at any character; restore the dataset, file
  format and data modality (hidden) columns
- size value columns with findable-ui fit-content widths and two-line
  clamps; per-column max widths come from the anvil15 value lengths
- replace the drs uri column with a download menu: download file (open
  access only) and copy drs uri; share the menu styles with request
  access
- remove the now unused copy cell and drs uri category key
- match sort header text exactly in the e2e sort helper, so "activity"
  no longer also matches "activity type"

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move AnVIL identity tags back to columns and add a file download menu

1 participant