Repository navigation
security: Fix pnpm audit alerts - #276
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Vite's resolved Sass compiler is downgraded below its declared supported version range.
1 open issue
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Updates the Angular application's dependencies to address reported security alerts.
Changes:
- Updates Angular packages to 22.2.3 and Model Context Protocol packages to 2.3.1.
- Adds a targeted Vite override, resolving to 8.3.4.
- Refreshes related transitive dependencies.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adds the Vite security override. |
| pnpm-lock.yaml | Records updated dependencies and peer resolutions. |
Review effort: Balanced
GoodDayForSurf
previously approved these changes
Oct 21, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency declarations, override, and lockfile are consistent, with no blocking issues identified.
No open issues 🎉
1 resolved since last review
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
Added in #212 to match devextreme-themebuilder 25.1's sass-embedded 1.66.0 for npm ci. With pnpm, @angular/build (1.104.1) and devextreme-themebuilder (1.93.3) use their own copies; nothing loads the root one.
GoodDayForSurf
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
@angular/router(GHSA-62vg-58rm-qff7, GHSA-57xq-rjx2-v5xh) and@modelcontextprotocol/server(GHSA-jm63-cq47-j5jp, GHSA-46jr-4wx8-v453, GHSA-rvq5-wwqv-78pq): lockfile update of@angular/*22.2.0 → 22.2.3vite(GHSA-587h-7wmj-h5pm, GHSA-698v-4r3x-3vcv, GHSA-r825-w8mm-5pxw): overridevite@>=8.3.0 <=8.3.2: ~8.3.3, because@angular/build22.2.x pins vite 8.3.0 (resolves to 8.3.4)Also
sass-embedded: 1.66.0pin. Re-resolving vite made@angular/build's vite pick it up as its optionalsass-embeddedpeer, below vite's^1.70.0. The pin dates from CI: Update ci scripts to use npm ci and swatch class fix #212, where it matcheddevextreme-themebuilder25.1's sass-embedded 1.66.0 fornpm ci. With pnpm,@angular/build(1.104.1) anddevextreme-themebuilder(1.93.3) bring their own copies, and tracing module loads during the theme build,ng buildandng serveshows nothing loads the root one. Without the pin, vite's peer resolves to 1.104.1, the generated themes are unchanged, theng buildstyles are byte-identical to master's, andpnpm peers checkmatches master.