Repository navigation
chore(ci): fix CI warnings - #419
Merged
Mathieu Morrissette (mmorrissette-devolutions) merged 8 commits intoOct 19, 2026
Merged
Conversation
download-artifact v4 -> v8, upload-artifact v4/v4.3.6 -> v7, setup-python v5 -> v7, setup-node v4 -> v7, setup-java v3 -> v6. Uploads previously pinned to v4.3.6 get include-hidden-files: true to keep including dotfiles, which v4.4+ excludes by default.
Drop package.homepage, which duplicates package.repository, and add description/license/repository to the python and uniffi crates that maturin packages.
cargo-deny flagged chacha20 0.10.1 as yanked.
Enable nullable reference types in the dotnet-core test project (the shared test files are annotated) and align MSTest with the local test project (3.7.1). MSTest 3.0.0 lacks [NotNull] on Assert.IsNotNull, which caused the CS8602/CS8604 warnings on android. Mark the iOS AppDelegate launchOptions parameter nullable to match the base member.
net9.0-android is out of support (NETSDK1202). CI already uses the .NET 10 SDK.
Replace kotlinOptions with compilerOptions and move the library targetSdk to testOptions/lint, as the library-level targetSdk is deprecated and removed in AGP 9.
Mathieu Morrissette (mmorrissette-devolutions)
requested a review
from a team
as a code owner
October 19, 2026 12:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Dion Gionet Mallet (dion-gionet)
previously approved these changes
Oct 19, 2026
Mathieu Morrissette (mmorrissette-devolutions)
dismissed
Dion Gionet Mallet (dion-gionet)’s stale review
October 19, 2026 13:43
The base branch was changed.
Dion Gionet Mallet (dion-gionet)
approved these changes
Oct 19, 2026
Mathieu Morrissette (mmorrissette-devolutions)
merged commit Oct 19, 2026
8aae105
into
master
28 checks passed
Mathieu Morrissette (mmorrissette-devolutions)
deleted the
fix/ci-warnings
branch
October 19, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #418. Fixes the warnings reported by CI run 38927727942.
Fixed
download-artifactv4 → v8,upload-artifactv4/v4.3.6 → v7,setup-pythonv5 → v7,setup-nodev4 → v7,setup-javav3 → v6 (also clears the "setup-java v3 is deprecated" warning). Uploads that were pinned to v4.3.6 getinclude-hidden-files: trueto keep the dotfile behaviour (v4.4+ excludes them by default). Artifacts are still zipped, sodv github download-artifactin the release workflows is unaffected.package.homepage(redundant withpackage.repository; printed on every cargo invocation). Adddescription/license/repositoryto thepythonanddevolutions-crypto-unifficrates (maturin'scargo package --listwarning).chacha200.10.1 → 0.10.2 (0.10.1 is yanked). The lockfile diff touches onlychacha20.dotnet-core: enable<Nullable>(the shared test files are annotated).android: bump MSTest 3.0.0 → 3.7.1, matching the local test project. MSTest 3.0.0 lacks[NotNull]onAssert.IsNotNull; reproduced locally (42 warnings with 3.0.0, 0 with 3.7.1).AppDelegate.FinishedLaunchingtakesNSDictionary?.net9.0-android→net10.0-android(CI already uses SDK 10). This is a separate commit, so it's easy to drop if needed.kotlinOptions→compilerOptions; librarytargetSdkmoved totestOptions/lint.Not fixed (out of this repo's control)
uniffi.toml"old-style --config": maturin passes the crate'suniffi.tomlto uniffi-bindgen 0.32 via--config. Python doesn't use the[bindings.kotlin]section, and rewriting the file risks the Kotlin package name.zip v2.4.2yanked,buf_redux/multipartfuture-incompat: these come from the wasm-pack / wasm-bindgen-cli lockfiles installed with--locked.WASM_BIGINT is deprecated: injected by rustc'swasm32-unknown-emscriptentarget, not by our flags.rand,getrandom,syn, …): this needs dependency-tree work and is out of scope.ubuntu-latest→ Ubuntu 26 migration) and the wasm-pack PATH hint.Verification
cargo test --lib: 46 passed.cargo package --listno longer prints manifest warnings.dotnet-coretest project (built against the source project) both build with 0 warnings.kotlin-androidlib builds with the new DSL (:lib:compileReleaseKotlin).