Repository navigation
feat(argon2): raise default memory cost to OWASP minimum (19 MiB) - #420
Merged
Mathieu Morrissette (mmorrissette-devolutions) merged 1 commit intoOct 19, 2026
Conversation
The default Argon2id parameters used 4 MiB / t=2 / p=1, which is below the OWASP Password Storage Cheat Sheet minimum (m=19 MiB, t=2, p=1). Raise the default memory to 19456 KiB and make `Argon2Parameters::default()` read the `defaults` constants instead of duplicating them. Existing data is unaffected: parameters are serialized with every derivation and read back from there. Password hashing (V2) already uses 64 MiB / t=3 and is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Sébastien Duquette (sduquette-devolutions)
approved these changes
Oct 19, 2026
Mathieu Morrissette (mmorrissette-devolutions)
merged commit Oct 19, 2026
d397703
into
master
34 checks passed
Mathieu Morrissette (mmorrissette-devolutions)
deleted the
security/argon2-owasp-defaults
branch
October 19, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the default Argon2id memory cost from 4 MiB to 19 MiB to match the OWASP minimum (m=19 MiB, t=2, p=1).