Repository navigation
Add Forms page to dev app and JsonForms vertical layout spacing - #347
Merged
Merged
Conversation
- Add a Forms page showing default MUI text fields (outlined, filled, standard) and selection controls, including read-only and disabled states - Add a JsonForms example with material renderers plus `JsonFormsControls`, with a switch for a read-only form - Compare the sci-react-ui read-only text controls with disabled JsonForms fields
- Add `JsonFormsControls.layoutRenderers`, a vertical layout that spaces fields like material's horizontal layout; hidden fields add no gap - Use it in the dev app's JsonForms examples - Document it in Helpers/JsonForms and the changelog
zoharma
force-pushed
the
zma/devapp-forms
branch
from
October 15, 2026 10:50
8ead27c to
be5dee8
Compare
zoharma
marked this pull request as ready for review
October 15, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev app Forms page: default MUI form controls and JsonForms, to check DiamondDSTheme in a downstream-like setup.
JsonFormsControls.layoutRenderers: a JsonForms vertical layout with spacing between fields. Material's vertical layout usesspacing: 0, so stacked fields touch. This one usesspacing={2}, the same gap as material's horizontal layout. Hidden fields add no extra gap. It's opt-in: