Repository navigation
Conversation
zoharma
force-pushed
the
zma/input-select-disabled-readonly
branch
2 times, most recently
from
October 12, 2026 13:56
4d2b8f6 to
b7043da
Compare
Collaborator
|
@zoharma What do you think about the contrast ratio between the Disabled label and the two-tone background. It's not very readable for me. |
Contributor
Author
@VictoriaBeilsten-Edmands I think this would be resolved in #359 States (post #356)
|
- Soften disabled and read-only surface tokens (light and dark) - Pass `disabled` to FormControl in the Select story so the label is disabled - Document the different read-only props on TextField and Select
zoharma
force-pushed
the
zma/input-select-disabled-readonly
branch
from
October 15, 2026 16:04
b7043da to
6e72724
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disabledto FormControl in the Select story so the label is disabled