Skip to content

Grey disabled JsonForms labels to match their inputs #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoharma merged 1 commit into from
Oct 16, 2026
+16 −2
Merged

Grey disabled JsonForms labels to match their inputs #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/components/helpers/jsonforms/layouts/VerticalLayout.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,13 @@ describe("VerticalLayout", () => {
expect(wrappers).toHaveLength(2);
expect(wrappers[1]).toBeEmptyDOMElement();
});

test("greys labels of disabled inputs", () => {
renderForm();
const css = Array.from(document.querySelectorAll("style"))
.map((style) => style.textContent)
.join("");
expect(css).toMatch(/:has\(> \.MuiInputBase-root\.Mui-disabled\)/);
expect(css).toMatch(/:has\(input:disabled\)/);
});
});
9 changes: 7 additions & 2 deletions src/components/helpers/jsonforms/layouts/VerticalLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,13 @@ const VerticalLayoutComponent = ({
<Stack
spacing={2}
useFlexGap
// Hidden fields render nothing; drop their wrappers so they add no gap.
sx={{ "& > :empty": { display: "none" } }}
sx={{
// Hidden fields render nothing; drop their wrappers so they add no gap.
"& > :empty": { display: "none" },
// Material renderers disable the input but not its label.
"& .MuiFormControl-root:has(> .MuiInputBase-root.Mui-disabled) > .MuiInputLabel-root, & .MuiFormControlLabel-root:has(input:disabled) > .MuiFormControlLabel-label":
{ color: "text.disabled" },
}}
>
{elements.map((child, index) => (
<div key={`${path}-${index}`}>
Expand Down
Loading