Repository navigation
Preserve timestamp casts when unit or timezone changes - #128
Merged
osipovartem merged 1 commit intoOct 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CAST/TRY_CASTin comparison andINexpressions when the unit or timezone changes. Widening an i64 timestamp can overflow, narrowing loses precision, and attaching a non-UTC timezone can shift values. Removing the cast changes strict errors, NULLs, and comparison results.Validation
cargo test -p datafusion-optimizer --lib --locked: 763 passed.cargo clippy -p datafusion-optimizer --lib --tests --locked: passed.Performance
The same change has been prepared for Apache DataFusion upstream. Rustice currently pins a divergent older fork SHA, so its dependency update will be handled separately rather than including unrelated fork changes here.