Skip to content

Keep semantic timestamp casts in physical comparison pruning - #130

Merged
osipovartem merged 2 commits into
embucket-sync-df55.0.0from
fix-df55-physical-timestamp-cast
Oct 10, 2026
Merged

osipovartem merged 2 commits into
embucket-sync-df55.0.0from
fix-df55-physical-timestamp-cast

Conversation

@osipovartem

Copy link
Copy Markdown
Collaborator

Summary

  • Prevent physical cast unwrapping from dropping timestamp unit conversions or timezone attachment in comparisons and pruning.
  • Share the semantic guard with the logical optimizer while preserving safe equal-unit timezone removal/replacement fast paths.
  • Add a two-row-group pruning regression that previously dropped a matching row group.

Validation

  • Focused tests: expr-common 166, optimizer 764, physical-expr 1609 (2 ignored), pruning 90.
  • Clippy and rustfmt passed for touched crates.
  • Independent read-only review approved correctness, performance, API, and test coverage. No GitHub self-review comments posted.

@osipovartem
osipovartem merged commit 7d8a646 into embucket-sync-df55.0.0 Oct 10, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant