Repository navigation
Avoid false AUTO zlib detection on printable CSV prefixes - #136
Merged
osipovartem merged 3 commits intoOct 10, 2026
Merged
Conversation
osipovartem
merged commit Oct 10, 2026
74db011
into
df55-copy-compression-auto
12 of 36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue filed; this fixes a reproducible
COPY INTO ... COMPRESSION=AUTOfailure on ordinary CSV input.Rationale for this change
An uncompressed CSV beginning with
80,passes the two-byte RFC 1950 zlib-header check.AUTOthen sends it to the DEFLATE decoder and fails the load. A focused live Snowflake COPY of the same plain input withCOMPRESSION=AUTOsucceeds.What changes are included in this PR?
DEFLATE.80,CSV, printable zlib-looking prefixes, genuine zlib, truncated input, and the six-byte noncandidate read path.Are these changes tested?
datafusion-datasource: 185/185;datafusion-datasource-csv: 13/13, with compression enabled.cargo clippy --all-targets --all-features -- -D warningsandcargo fmt --all -- --checkpass locally.Are there any user-facing changes?
COMPRESSION=AUTOno longer misclassifies this class of plain CSV as zlib. A finite prefix cannot disambiguate every stream; users can still specifyDEFLATEorNONEfor ambiguous files. No public API change.